You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
api [nfc]: Mark all never-updated User fields final
This was prompted by noticing recently that we weren't updating
[User.isActive]:
zulip#816 (comment)
After fixing that, I looked and found there were actually three
other fields on User which we weren't updating -- a latent bug,
since we never looked at those fields, but a bug. Fixed that in
the preceding commit.
Now the remaining fields that don't get updated are fields that
really are immutable on a Zulip user. Mark those as final, and
add a comment to help maintain the pattern.
0 commit comments