GuzzleHandler now accepts errors as well as exceptions on failure #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…patibility) Fixes: gmponos#48
…rors are added to the body of the RejectionException from the promise
ossycodes
changed the title
This was referenced Aug 29, 2023
|
@gmponos any chance of getting this merged please? 🙏 |
Author
|
@gmponos any update here please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extend @mwolff-fn PR #50 plus new changes GuzzleHandler now accepts errors as well as exceptions on failure, so this line causes an issue return function (\Exception $reason) use ($request, $options) {.....}, my pr fixes this