Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify utility tests for flow #626

Closed
kidrahahjo opened this issue Mar 11, 2022 · 0 comments
Closed

Simplify utility tests for flow #626

kidrahahjo opened this issue Mar 11, 2022 · 0 comments
Assignees
Labels
good first issue Good for newcomers
Milestone

Comments

@kidrahahjo
Copy link
Collaborator

kidrahahjo commented Mar 11, 2022

Feature description

We test a lot of utility behaviour in single functions in https://github.com/glotzerlab/signac-flow/blob/master/tests/test_util.py.

Related to the work discussed in #611

Proposed solution

Break down the tests for _bidict and Template Filters into smaller tests.

Additional context

test_calc_memory tests the result of calc_memory when operations are run in series and in parallel in a single function.
Write two seperate functions test_calc_memory_serial and test_calc_memory_parallel and test the results accordingly.

@kidrahahjo kidrahahjo added the good first issue Good for newcomers label Mar 11, 2022
@kidrahahjo kidrahahjo added this to the v0.19.0 milestone Mar 11, 2022
@cbkerr cbkerr modified the milestones: v0.19.0, v.0.20.0 Apr 7, 2022
@b-butler b-butler modified the milestones: v0.20.0, v1.0 Jun 23, 2022
@iblanco11981870 iblanco11981870 self-assigned this Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants