Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical alignment on small buttons is off #44

Open
taravancil opened this issue Sep 6, 2019 · 5 comments
Open

Vertical alignment on small buttons is off #44

taravancil opened this issue Sep 6, 2019 · 5 comments
Assignees

Comments

@taravancil
Copy link

Screen Shot 2019-09-06 at 10 19 31 AM

Screen Shot 2019-09-06 at 10 18 19 AM

There are some prior emoji-in-button alignment discussions + screenshots in this ~community PR

@taravancil
Copy link
Author

@ttseng tagging you in here to make sure we're carrying over your decisions from our earlier discussions about button text alignment

@ttseng
Copy link
Contributor

ttseng commented Sep 6, 2019

ah, we tried to get the alignment right in allyson's PR (https://github.com/FogCreek/Glitch-Community/pull/851#issuecomment-527490822) but looks like it's still a little off - thanks for reporting!

@ttseng ttseng self-assigned this Sep 6, 2019
@sarahzinger
Copy link
Contributor

it also looks like the emojis have gotten pretty small:
Screen Shot 2019-09-10 at 10 04 29 AM

I can't see them very well, perhaps we can make them bigger? cc @ttseng @whimsicallyson

@ttseng
Copy link
Contributor

ttseng commented Sep 10, 2019

thanks for sharing this image @sarahzinger! I agree that they're harder to parse at the current size - am taking a look into it now.

@sarahzinger
Copy link
Contributor

cool! also not sure if this is related but it is emoji related: https://app.zenhub.com/workspaces/community-5d07d1359dee6059a9688176/issues/fogcreek/glitch-community-work/414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants