Fix clippy warnings

Author: GearsDatapacks

.github/workflows/ci.yaml

@@ -286,7 +286,7 @@ jobs:
 
       - uses: actions/setup-node@v4
         with:
-          node-version: "18"
+          node-version: "20"
 
       - name: Install wasm-pack
         run: |

compiler-core/src/dependency.rs

@@ -69,7 +69,7 @@ fn parse_exact_version(ver: &str) -> Option<Version> {
     let first_byte = version.as_bytes().first();
 
     // Version is exact if it starts with an explicit == or a number
-    if version.starts_with("==") || first_byte.map_or(false, |v| v.is_ascii_digit()) {
+    if version.starts_with("==") || first_byte.is_some_and(|v| v.is_ascii_digit()) {
         let version = version.replace("==", "");
         let version = version.as_str().trim();
         if let Ok(v) = Version::parse(version) {

compiler-core/src/language_server/code_action.rs

@@ -2296,7 +2296,7 @@ impl<'a> DesugarUse<'a> {
 
         // If there's arguments on the left hand side of the function we extract
         // those so we can paste them back as the anonymous function arguments.
-        let assignments = if type_.fn_arity().map_or(false, |arity| arity >= 1) {
+        let assignments = if type_.fn_arity().is_some_and(|arity| arity >= 1) {
             let assignments_range =
                 use_.assignments_location.start as usize..use_.assignments_location.end as usize;
             self.module

test-helpers-rs/src/lib.rs

@@ -5,7 +5,7 @@ use gleam_core::{
 };
 use itertools::Itertools;
 use regex::Regex;
-use std::{collections::HashMap, fmt::Write, sync::OnceLock};
+use std::{collections::HashMap, fmt::Write, sync::LazyLock};
 
 #[derive(Debug)]
 pub struct TestCompileOutput {
@@ -45,9 +45,6 @@ impl TestCompileOutput {
 
                 Content::Text(text) => {
                     let text = FILE_LINE_REGEX
-                        .get_or_init(|| {
-                            Regex::new(r#"-file\("([^"]+)", (\d+)\)\."#).expect("Invalid regex")
-                        })
                         .replace_all(text, |caps: &regex::Captures| {
                             let path = caps
                                 .get(1)
@@ -95,7 +92,8 @@ pub fn to_in_memory_filesystem(path: &Utf8Path) -> InMemoryFileSystem {
     fs
 }
 
-static FILE_LINE_REGEX: OnceLock<Regex> = OnceLock::new();
+static FILE_LINE_REGEX: LazyLock<Regex> =
+    LazyLock::new(|| Regex::new(r#"-file\("([^"]+)", (\d+)\)\."#).expect("Invalid regex"));
 
 pub fn normalise_diagnostic(text: &str) -> String {
     // There is an extra ^ on Windows in some error messages' code