Skip to content

gh-410: Port straightforward functions in observations #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Oct 22, 2025
Merged

gh-410: Port straightforward functions in observations #677

merged 20 commits into from
Oct 22, 2025

Conversation

@connoraird
Copy link
Contributor

@connoraird connoraird commented Oct 17, 2025 •
edited
Loading

Description

Ported straight forward functions in observations

Some functionality previously implemented here has been split out into PR-681 and PR-680

Closes: #410

Changelog entry

Added: Ported several functions within observations and one in lensing to the array-api (#410)

Checks

  • Is your code passing linting?
  • Is your code passing tests?
  • Have you added additional tests (if required)?
  • Have you modified/extended the documentation (if required)?
  • Have you added a one-liner changelog entry above (if required)?

@connoraird connoraird changed the title Connor/issue 410 gh-410 and gh-676: Port straightforward function in observations and remove UnifiedGenerator Oct 17, 2025
@connoraird connoraird changed the base branch from main to connor/issue-409 October 17, 2025 12:14
@connoraird connoraird requested a review from paddyroddy October 17, 2025 12:48
@connoraird connoraird self-assigned this Oct 17, 2025
@connoraird connoraird requested a review from ntessore October 17, 2025 13:22
paddyroddy
paddyroddy requested changes Oct 17, 2025
View reviewed changes
Copy link
Member

@paddyroddy paddyroddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started reviewing, but I think this PR is too big. Can we split some of this stuff up?

Incidentally I was doing some of this myself, but you beat me to it haha

Base automatically changed from connor/issue-409 to main October 17, 2025 16:29
This was referenced Oct 17, 2025
Merged
Merged
@connoraird connoraird marked this pull request as draft October 17, 2025 16:57
@connoraird connoraird changed the base branch from main to connor/issue-679 October 17, 2025 17:08
@connoraird connoraird requested review from paddyroddy and removed request for ntessore and paddyroddy October 17, 2025 17:11
@connoraird connoraird added the array-api Work is related to the Array API label Oct 17, 2025
@connoraird connoraird changed the title gh-410 and gh-676: Port straightforward function in observations and remove UnifiedGenerator gh-410: Port straightforward function in observations Oct 20, 2025
@connoraird connoraird marked this pull request as ready for review October 20, 2025 08:34
@connoraird connoraird requested a review from paddyroddy October 20, 2025 08:34
@connoraird connoraird changed the title gh-410: Port straightforward function in observations gh-410: Port straightforward functions in observations Oct 20, 2025
@connoraird
Copy link
Contributor Author

connoraird commented Oct 20, 2025

This may rely on #681 before the tests will pass

@paddyroddy paddyroddy marked this pull request as draft October 20, 2025 09:57
@paddyroddy
Copy link
Member

paddyroddy commented Oct 20, 2025

Converted to draft until tests pass

Base automatically changed from connor/issue-679 to main October 20, 2025 13:03
@connoraird connoraird marked this pull request as ready for review October 20, 2025 13:22
paddyroddy
paddyroddy requested changes Oct 20, 2025
View reviewed changes
Copy link
Member

@paddyroddy paddyroddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main thing just to update docstrings

@connoraird connoraird requested a review from paddyroddy October 20, 2025 14:15
paddyroddy
paddyroddy reviewed Oct 20, 2025
View reviewed changes
Copy link
Member

@paddyroddy paddyroddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thought

@connoraird connoraird requested a review from paddyroddy October 22, 2025 09:00
@paddyroddy
Copy link
Member

paddyroddy commented Oct 22, 2025

Need to remove pytest.approx

@connoraird
Copy link
Contributor Author

connoraird commented Oct 22, 2025

Need to remove pytest.approx

Done

@paddyroddy
Copy link
Member

paddyroddy commented Oct 22, 2025

Docs failing

paddyroddy
paddyroddy requested changes Oct 22, 2025
View reviewed changes
@connoraird connoraird requested a review from paddyroddy October 22, 2025 13:23
@connoraird connoraird merged commit f87a698 into main Oct 22, 2025
12 checks passed
@connoraird connoraird deleted the connor/issue-410 branch October 22, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paddyroddy paddyroddy paddyroddy approved these changes

Assignees

@connoraird connoraird

Labels

array-api Work is related to the Array API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Array API: port straightforward functions in observations

3 participants

@connoraird @paddyroddy