Merge pull request #19 from gl-vis/fix-missing-points

Fix missing points

Author: dy

package-lock.json

@@ -39,7 +39,7 @@
     "object-assign": "^4.1.1",
     "parse-rect": "^1.2.0",
     "pick-by-alias": "^1.2.0",
-    "point-cluster": "^3.1.4",
+    "point-cluster": "^3.1.5",
     "to-float32": "^1.0.1",
     "update-diff": "^1.1.0"
   },

package.json

@@ -66,13 +66,17 @@ t('1e6 points', async t => {
 	}
 
 	var scatter = createScatter(regl)
+	console.time('update')
 	scatter.update({
 		positions: positions,
 		size: 4,
 		color: [0,0,0,.1],
 		range: [-.1,-.1,1.1,1.1]
 	})
+	console.timeEnd('update')
+	console.time('draw')
 	scatter.draw()
+	console.timeEnd('draw')
 
 	t.ok(eq(scatter.gl, await load('./test/img/1e6.png'), .1))
 	regl.clear({color: [0,0,0,0]})
@@ -99,6 +103,53 @@ t('Color palette interference (#3232)', async t => {
 	t.end()
 })
 
+
+t('missing points simple', async t => {
+	var scatter = createScatter(regl)
+
+	var data = []
+
+	for (let i = 0; i < 20; i++) {
+		data.push(+(new Date(i)), 0)
+	}
+
+	scatter.update([{
+		positions: data,
+		size: 4,
+		snap: true,
+		range: [0, -10, 20, 10]
+	}])
+	scatter.render()
+
+	t.ok(eq(scatter, await load('./test/img/missing-points-simple.png'), {threshold: .1}))
+
+	regl.clear({color: [0,0,0,0]})
+	t.end()
+})
+
+t('missing points #2334', async t => {
+	var scatter = createScatter(regl)
+
+	var data = []
+
+	for (let i = 0; i < 41111; i++) {
+		data.push(i, 0)
+	}
+
+	scatter.update([{
+		positions: data,
+		size: 3,
+		snap: true,
+		range: [0,-10,50,10]
+	}])
+	scatter.render()
+
+	t.ok(eq(scatter, await load('./test/img/missing-points-2334.png'), {threshold: .1}))
+
+	regl.clear({color: [0,0,0,0]})
+	t.end()
+})
+
 t('unsnapped elements render')
 
 t('snapped elements render')
@@ -125,4 +176,3 @@ t('no-boundaries')
 
 t('cluster with external buffer')
 
-