Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension does not work with Hugo versions above v0.88.1 #19

Open
PalmEmanuel opened this issue Nov 7, 2021 · 2 comments · May be fixed by #20
Open

Extension does not work with Hugo versions above v0.88.1 #19

PalmEmanuel opened this issue Nov 7, 2021 · 2 comments · May be fixed by #20

Comments

@PalmEmanuel
Copy link

PalmEmanuel commented Nov 7, 2021

The extension finds the Windows 64 release by looking at if the name of the asset matches '*Windows*64*'.

$win64hugo = $release.assets | where { $_.name -like '*Windows*64*' }

Up until version 0.88.1 this only matched on hugo_<version>_Windows-64bit.zip but after version 0.89 it also matches on a new asset called hugo_<version>_Windows-ARM64.zip.

The logic for finding the download URL for the version should change to handle this new asset in the Hugo releases.

@gaelcolas
Copy link

Yep, we hit the same problem here:
https://dev.azure.com/dsccommunity/dsccommunity.org/_build/results?buildId=5252&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=2d65d1e2-3936-5248-963b-4ff25d1b8072

Updating the line with this should do the trick:
$win64hugo = $release.assets | where { $_.name -like '*Windows-64*' }
or we could go for a regex match instead:
$win64hugo = $release.assets | where { $_.name -match 'Windows\-64.*' }

gaelcolas added a commit to gaelcolas/hugo-vsts-extension that referenced this issue Nov 17, 2021
Fix giuliov#19 that was matching a new Asset for Windows ARM64.
Updating the `-like` to be more specific.
@gaelcolas gaelcolas linked a pull request Nov 17, 2021 that will close this issue
@giuliov
Copy link
Owner

giuliov commented Jan 3, 2022

Solved in version 2.0 and above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants