From cab27e10388b6c993a4ed98077c504ec178e2997 Mon Sep 17 00:00:00 2001 From: Sergei Shmakov Date: Thu, 16 Jan 2025 00:49:57 +0100 Subject: [PATCH] Prevents caching a Cloud GitHub Enterprise integration without domain (#3901) --- src/plus/integrations/integrationService.ts | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/plus/integrations/integrationService.ts b/src/plus/integrations/integrationService.ts index 4ead07c9bfc43..b408da716bc79 100644 --- a/src/plus/integrations/integrationService.ts +++ b/src/plus/integrations/integrationService.ts @@ -479,17 +479,19 @@ export class IntegrationService implements Disposable { SelfHostedIntegrationId.CloudGitHubEnterprise, ); if (existingConfigured?.length) { - const { domain } = existingConfigured[0]; - if (domain == null) throw new Error(`Domain is required for '${id}' integration`); + const { domain: configuredDomain } = existingConfigured[0]; + if (configuredDomain == null) throw new Error(`Domain is required for '${id}' integration`); integration = new ( await import(/* webpackChunkName: "integrations" */ './providers/github') ).GitHubEnterpriseIntegration( this.container, this.authenticationService, this.getProvidersApi.bind(this), - domain, + configuredDomain, id, ); + // assign domain because it's part of caching key: + domain = configuredDomain; break; }