Skip to content

Commit c415871

Browse files
authored
refactor: external link indicators (#2310)
Signed-off-by: Adam Setch <[email protected]>
1 parent 7312b0e commit c415871

File tree

5 files changed

+67
-67
lines changed

5 files changed

+67
-67
lines changed

src/renderer/components/Sidebar.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ export const Sidebar: FC = () => {
9898
<IconButton
9999
aria-label="Notifications"
100100
data-testid="sidebar-notifications"
101-
description={`${notificationsCount} unread notifications`}
101+
description={`${notificationsCount} unread notifications`}
102102
icon={BellIcon}
103103
onClick={() => openGitHubNotifications(primaryAccountHostname)}
104104
size="small"
@@ -124,7 +124,7 @@ export const Sidebar: FC = () => {
124124
)}
125125

126126
<IconButton
127-
aria-label="My issues"
127+
aria-label="My issues"
128128
data-testid="sidebar-my-issues"
129129
icon={IssueOpenedIcon}
130130
onClick={() => openGitHubIssues(primaryAccountHostname)}
@@ -136,7 +136,7 @@ export const Sidebar: FC = () => {
136136
/>
137137

138138
<IconButton
139-
aria-label="My pull requests"
139+
aria-label="My pull requests"
140140
data-testid="sidebar-my-pull-requests"
141141
icon={GitPullRequestIcon}
142142
onClick={() => openGitHubPulls(primaryAccountHostname)}

src/renderer/components/__snapshots__/Sidebar.test.tsx.snap

Lines changed: 12 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/renderer/components/layout/__snapshots__/AppLayout.test.tsx.snap

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/renderer/components/notifications/AccountNotifications.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,14 +105,14 @@ export const AccountNotifications: FC<IAccountNotifications> = (
105105
<HoverButton
106106
action={() => openGitHubIssues(account.hostname)}
107107
icon={IssueOpenedIcon}
108-
label="My Issues"
108+
label="My issues ↗"
109109
testid="account-issues"
110110
/>
111111

112112
<HoverButton
113113
action={() => openGitHubPulls(account.hostname)}
114114
icon={GitPullRequestIcon}
115-
label="My Pull Requests"
115+
label="My pull requests ↗"
116116
testid="account-pull-requests"
117117
/>
118118

0 commit comments

Comments
 (0)