Skip to content

Commit 531427a

Browse files
authored
23.1.1+1.28.5 (#60)
* fix role names in .github/workflows/release.yml * fix typo in README * clusterRoleBinding system:kube-apiserver needs to honor k8s_apiserver_csr_cn value for as username
1 parent 0f4f372 commit 531427a

6 files changed

+25
-11
lines changed

.github/workflows/release.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ on:
1313

1414
defaults:
1515
run:
16-
working-directory: 'githubixx.kubernetes-controller'
16+
working-directory: 'githubixx.kubernetes_controller'
1717

1818
jobs:
1919
release:
@@ -23,7 +23,7 @@ jobs:
2323
- name: Check out the codebase.
2424
uses: actions/checkout@v2
2525
with:
26-
path: 'githubixx.kubernetes-controller'
26+
path: 'githubixx.kubernetes_controller'
2727

2828
- name: Set up Python 3.
2929
uses: actions/setup-python@v2

CHANGELOG.md

+10-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
11
# Changelog
22

3+
## 23.1.1+1.28.5
4+
5+
### BUGFIX
6+
7+
- ClusterRoleBinding `system:kube-apiserver` needs to honor `k8s_apiserver_csr_cn` value for as username
8+
- Because of the previous change move `files/kube-apiserver-to-kubelet_cluster_role.yaml -> templates/rbac/kube-apiserver-to-kubelet_cluster_role.yaml.j2` and `files/kube-apiserver-to-kubelet_cluster_role_binding.yaml -> templates/rbac/kube-apiserver-to-kubelet_cluster_role_binding.yaml.j2` as both files became a Jinja2 template.
9+
310
## 23.1.0+1.28.5
411

512
### MOLECULE
@@ -9,14 +16,14 @@
916

1017
### OTHER CHANGES
1118

12-
- fix permissions for temporary directory
13-
- adjust Github action because of Ansible Galaxy changes
19+
- Fix permissions for temporary directory
20+
- Adjust Github action because of Ansible Galaxy changes
1421

1522
## 23.0.0+1.28.5
1623

1724
### UPDATE
1825

19-
- update `k8s_release` to `1.28.5`
26+
- Update `k8s_release` to `1.28.5`
2027

2128
### BREAKING
2229

README.md

+8-1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,13 @@ See full [CHANGELOG.md](https://github.com/githubixx/ansible-role-kubernetes-con
2323

2424
**Recent changes:**
2525

26+
## 23.1.1+1.28.5
27+
28+
### BUGFIX
29+
30+
- ClusterRoleBinding `system:kube-apiserver` needs to honor `k8s_apiserver_csr_cn` value for as username
31+
- Because of the previous change move `files/kube-apiserver-to-kubelet_cluster_role.yaml -> templates/rbac/kube-apiserver-to-kubelet_cluster_role.yaml.j2` and `files/kube-apiserver-to-kubelet_cluster_role_binding.yaml -> templates/rbac/kube-apiserver-to-kubelet_cluster_role_binding.yaml.j2` as both files became a Jinja2 template.
32+
2633
## 23.1.0+1.28.5
2734

2835
### MOLECULE
@@ -149,7 +156,7 @@ er on the Ansible controller host. Previously it was needed to prepare these fil
149156

150157
## Installation
151158

152-
- Directly download from Github (Change into Ansible role directory before cloning. You can figure out the role path by using `ansible-config dump | grep DEFAULT_ROLES_PATH` command):
159+
- Directly download from Github (Change into Ansible roles directory before cloning. You can figure out the role path by using `ansible-config dump | grep DEFAULT_ROLES_PATH` command):
153160
`git clone https://github.com/githubixx/ansible-role-kubernetes-controller.git githubixx.kubernetes_controller`
154161

155162
- Via `ansible-galaxy` command and download directly from Ansible Galaxy:

tasks/main.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -314,17 +314,17 @@
314314
changed_when: false
315315

316316
- name: Copy kube-apiserver-to-kubelet ClusterRole
317-
ansible.builtin.copy:
318-
src: "files/kube-apiserver-to-kubelet_cluster_role.yaml"
317+
ansible.builtin.template:
318+
src: "rbac/kube-apiserver-to-kubelet_cluster_role.yaml.j2"
319319
dest: "{{ k8s_ctl__tmp_dir.path }}/kube-apiserver-to-kubelet_cluster_role.yaml"
320320
mode: 0644
321321
run_once: true
322322
delegate_to: "{{ k8s_ctl_delegate_to }}"
323323
changed_when: false
324324

325325
- name: Copy kube-apiserver-to-kubelet ClusterRoleBinding
326-
ansible.builtin.copy:
327-
src: "files/kube-apiserver-to-kubelet_cluster_role_binding.yaml"
326+
ansible.builtin.template:
327+
src: "rbac/kube-apiserver-to-kubelet_cluster_role_binding.yaml.j2"
328328
dest: "{{ k8s_ctl__tmp_dir.path }}/kube-apiserver-to-kubelet_cluster_role_binding.yaml"
329329
mode: 0644
330330
run_once: true

files/kube-apiserver-to-kubelet_cluster_role_binding.yaml renamed to templates/rbac/kube-apiserver-to-kubelet_cluster_role_binding.yaml.j2

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@ roleRef:
1111
subjects:
1212
- apiGroup: rbac.authorization.k8s.io
1313
kind: User
14-
name: kubernetes
14+
name: {{ k8s_apiserver_csr_cn }}

0 commit comments

Comments
 (0)