Skip to content

Commit 063800c

Browse files
authoredJan 8, 2025··
Fix existing existing environment variable filter (#717)
This boolean was reversed when filtering existing variables, so it consistently sent a POST request to existing vars. Signed-off-by: Kyle Harding <kyle@balena.io>
1 parent ee5909a commit 063800c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed
 

‎lib/plugins/environments.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ module.exports = class Environments extends Diffable {
167167
for (const variable of attrs.variables) {
168168
const existingVariable = existingVariables.find((_var) => _var.name === variable.name)
169169
if (existingVariable) {
170-
existingVariables = existingVariables.filter(_var => _var.name !== variable.name)
170+
existingVariables = existingVariables.filter(_var => _var.name === variable.name)
171171
if (existingVariable.value !== variable.value) {
172172
await this.github.request('PATCH /repos/:org/:repo/environments/:environment_name/variables/:variable_name', {
173173
org: this.repo.owner,

0 commit comments

Comments
 (0)
Please sign in to comment.