Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tool names in sarif output #23

Open
Daverlo opened this issue Jan 27, 2021 · 6 comments
Open

Improve tool names in sarif output #23

Daverlo opened this issue Jan 27, 2021 · 6 comments

Comments

@Daverlo
Copy link

Daverlo commented Jan 27, 2021

@davidknise You seem to be the main maintainer of this repo.

Bandit and Gosec are using the name property for outputting a description (Security audit for python by bandit and Golang security checks by gosec).

At Github Code Scanning, we use those names for displaying the tool at the Security page. We added some internal logic for handling these special cases and rename them to the tool name, but we are in the process of cleaning up the code and removing it. We suggest using the name property for outputing the tool name (Bandit, and Gosec), and the fullName or short/longDescription properties for storing the current long name.

@davidknise
Copy link
Contributor

Acknowledged. Those names should be Bandit and gosec, so I will file a bug on in the MSCA CLI and get that deployed.

@anaarmas
Copy link

Thank you @davidknise 🙇‍♀️ !
Is that repo open source? If so would you mind sharing a link to that issue so we can keep track of progress without pestering you too much 😅 Otherwise would you mind keeping us posted on progress?

@Daverlo
Copy link
Author

Daverlo commented Mar 5, 2021

@davidknise What's the current status? Could you give us an update please? :)

@davidknise
Copy link
Contributor

davidknise commented Apr 8, 2021

@anaarmas, @Daverlo my apologies for the late response,

Is that repo open source?

It is not.

Otherwise would you mind keeping us posted on progress?
What's the current status? Could you give us an update please? :)

I thought we had this scheduled and am surprised to see it hasn't been deployed yet. I will follow up today to ensure it's in our pipeline.

@anaarmas
Copy link

Hi @davidknise, @massto 👋
Does the above message mean this change has already been deployed and we can close this issue?

@anaarmas
Copy link

anaarmas commented Jul 22, 2021

@davidknise @massto following up on this again - can this issue be closed now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@davidknise @Daverlo @anaarmas and others