Skip to content

Commit c629867

Browse files
authored
Merge pull request #17654 from michaelnebel/modelgen/mixedbugfix
C#/Java: Only use heuristic if no content based model exist (in mixed mode).
2 parents 8542992 + 51623c3 commit c629867

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

java/ql/src/Metrics/Summaries/GeneratedVsManualCoverageQuery.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@ private int getNumMadModeledApis(string package, string provenance, string apiSu
1717
(
1818
// "auto-only"
1919
not sc.hasManualModel() and
20-
sc.hasProvenance("df-generated") and
20+
sc.hasGeneratedModel() and
2121
provenance = "generated"
2222
or
2323
sc.hasManualModel() and
2424
(
25-
if sc.hasProvenance("df-generated")
25+
if sc.hasGeneratedModel()
2626
then
2727
// "both"
2828
provenance = "both"

shared/mad/codeql/mad/modelgenerator/internal/ModelGeneratorImpl.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -881,7 +881,7 @@ module MakeModelGenerator<
881881
string captureMixedFlow(DataFlowSummaryTargetApi api, boolean lift) {
882882
result = ContentSensitive::captureFlow(api, lift)
883883
or
884-
not exists(ContentSensitive::captureFlow(api, lift)) and
884+
not exists(ContentSensitive::captureFlow(api, _)) and
885885
result = captureFlow(api) and
886886
lift = true
887887
}

0 commit comments

Comments
 (0)