Update ConstLikeReturnValue to the new dataflow library

Note that there's a small issue here where the dataflow library causes one of
the results to get duplicated.

Author: jketema

cpp/common/src/codingstandards/cpp/rules/constlikereturnvalue/ConstLikeReturnValue.qll

@@ -8,7 +8,7 @@
 import cpp
 import codingstandards.cpp.Customizations
 import codingstandards.cpp.Exclusions
-import semmle.code.cpp.dataflow.DataFlow
+import semmle.code.cpp.dataflow.new.DataFlow
 import DFFlow::PathGraph
 
 abstract class ConstLikeReturnValueSharedQuery extends Query { }

cpp/common/test/rules/constlikereturnvalue/ConstLikeReturnValue.expected

@@ -1,20 +1,29 @@
 problems
-| test.cpp:11:8:11:12 | c_str | test.cpp:18:16:18:21 | call to getenv | test.cpp:11:8:11:12 | c_str | The object returned by the function getenv should not be modified. |
+| test.cpp:11:7:11:12 | * ... | test.cpp:18:16:18:21 | call to getenv | test.cpp:11:7:11:12 | * ... | The object returned by the function getenv should not be modified. |
+| test.cpp:11:8:11:12 | c_str | test.cpp:18:16:18:21 | call to getenv | test.cpp:11:7:11:12 | * ... | The object returned by the function getenv should not be modified. |
 | test.cpp:67:5:67:9 | conv4 | test.cpp:64:11:64:20 | call to localeconv | test.cpp:67:5:67:9 | conv4 | The object returned by the function localeconv should not be modified. |
 | test.cpp:76:5:76:8 | conv | test.cpp:72:25:72:34 | call to localeconv | test.cpp:76:5:76:8 | conv | The object returned by the function localeconv should not be modified. |
 edges
-| test.cpp:8:18:8:22 | c_str | test.cpp:11:8:11:12 | c_str | provenance |  |
+| test.cpp:8:18:8:22 | c_str | test.cpp:11:7:11:12 | * ... | provenance |  |
+| test.cpp:18:16:18:21 | call to getenv | test.cpp:18:16:18:21 | call to getenv | provenance |  |
 | test.cpp:18:16:18:21 | call to getenv | test.cpp:24:9:24:12 | env1 | provenance |  |
 | test.cpp:24:9:24:12 | env1 | test.cpp:8:18:8:22 | c_str | provenance |  |
-| test.cpp:64:11:64:20 | call to localeconv | test.cpp:67:5:67:9 | conv4 | provenance |  |
-| test.cpp:72:25:72:34 | call to localeconv | test.cpp:76:5:76:8 | conv | provenance |  |
+| test.cpp:64:3:64:22 | ... = ... | test.cpp:67:5:67:9 | conv4 | provenance |  |
+| test.cpp:64:11:64:20 | call to localeconv | test.cpp:64:3:64:22 | ... = ... | provenance |  |
+| test.cpp:72:25:72:34 | call to localeconv | test.cpp:72:25:72:34 | call to localeconv | provenance |  |
+| test.cpp:72:25:72:34 | call to localeconv | test.cpp:73:24:73:28 | conv4 | provenance |  |
+| test.cpp:73:24:73:28 | conv4 | test.cpp:76:5:76:8 | conv | provenance |  |
 nodes
 | test.cpp:8:18:8:22 | c_str | semmle.label | c_str |
-| test.cpp:11:8:11:12 | c_str | semmle.label | c_str |
+| test.cpp:11:7:11:12 | * ... | semmle.label | * ... |
+| test.cpp:18:16:18:21 | call to getenv | semmle.label | call to getenv |
 | test.cpp:18:16:18:21 | call to getenv | semmle.label | call to getenv |
 | test.cpp:24:9:24:12 | env1 | semmle.label | env1 |
+| test.cpp:64:3:64:22 | ... = ... | semmle.label | ... = ... |
 | test.cpp:64:11:64:20 | call to localeconv | semmle.label | call to localeconv |
 | test.cpp:67:5:67:9 | conv4 | semmle.label | conv4 |
 | test.cpp:72:25:72:34 | call to localeconv | semmle.label | call to localeconv |
+| test.cpp:72:25:72:34 | call to localeconv | semmle.label | call to localeconv |
+| test.cpp:73:24:73:28 | conv4 | semmle.label | conv4 |
 | test.cpp:76:5:76:8 | conv | semmle.label | conv |
 subpaths