Remove useage of group in the idSelection retain

The selection ID does not make use of the notion of groups, so we can add a special case to the id type for the selectionKey function

Author: Caleb-T-Owens

apps/desktop/src/components/v3/WorktreeChanges.svelte

@@ -66,8 +66,9 @@
 		if (affectedPaths) {
 			untrack(() => {
 				changeSelection.retain(affectedPaths);
-				// TODO: We need to make this consider all groups
-				idSelection.retain(affectedPaths, { type: 'ungrouped' });
+				// TODO: Consider whether this is the best place for this to
+				// live.
+				idSelection.retain(affectedPaths);
 			});
 		}
 	});

apps/desktop/src/lib/selection/idSelection.svelte.ts

@@ -7,7 +7,6 @@ import {
 	type SelectedFile
 } from '$lib/selection/key';
 import { SvelteSet } from 'svelte/reactivity';
-import type { HunkGroup } from '$lib/hunks/diffService.svelte';
 import type { StackService } from '$lib/stacks/stackService.svelte';
 import type { WorktreeService } from '$lib/worktree/worktreeService.svelte';
 
@@ -136,13 +135,13 @@ export class IdSelection {
 	 * current worktree changes. Note that this function is a special case
 	 * for a particular key. It feels a bit out of place.
 	 */
-	retain(paths: string[] | undefined, group: HunkGroup) {
+	retain(paths: string[] | undefined) {
 		if (paths === undefined) {
 			this.selections.clear();
 			return;
 		}
 		const removedFiles: SelectedFile[] = [];
-		const worktreeSelection = this.selections.get(selectionKey({ type: 'worktree', group }));
+		const worktreeSelection = this.selections.get(selectionKey({ type: 'worktree' }));
 		if (!worktreeSelection) return;
 
 		for (const selectedFile of worktreeSelection.entries) {

apps/desktop/src/lib/selection/key.ts

@@ -77,7 +77,7 @@ export function readKey(key: SelectedFileKey): SelectedFile {
 	}
 }
 
-export function selectionKey(id: SelectionId): SelectedFileKey {
+export function selectionKey(id: SelectionId | { type: 'worktree' }): SelectedFileKey {
 	switch (id.type) {
 		case 'commit':
 			return `${id.type}:${id.commitId}` as SelectedFileKey;