Skip to content

Commit 4a460b4

Browse files
committed
Fix build in Visual Studio
Building in Visual Studio causes some tasks to be run concurrently that would be run in a specific order in MSBuild instead. The symptom would look like this: MSB4044: The "GenerateWindowsAppManifest" task was not given a value for the required parameter "Version". Let's help Visual Studio realize that there are certain dependencies between the `GetVersion` and the `GenerateWindowsAppManifest` task. Reported by Michael J. Lyons. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 415adfe commit 4a460b4

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

Directory.Build.targets

+2-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<Import Project="$(RepoPath)build\GCM.tasks" />
77

88
<!-- Use version specified in VERSION file -->
9-
<Target Name="GetVersion" BeforeTargets="BeforeBuild">
9+
<Target Name="GetVersion" BeforeTargets="BeforeBuild;GenerateWindowsAppManifest">
1010
<GetVersion VersionFile="$(RepoPath)VERSION">
1111
<Output TaskParameter="Version" PropertyName="Version" />
1212
<Output TaskParameter="AssemblyVersion" PropertyName="AssemblyVersion" />
@@ -21,6 +21,7 @@
2121

2222
<!-- Generate the manifest file before we set the win32 manifest properties -->
2323
<Target Name="GenerateWindowsAppManifest"
24+
AfterTargets="GetVersion"
2425
BeforeTargets="SetWin32ManifestProperties"
2526
Condition="'$(GenerateWindowsAppManifest)' != 'false'"
2627
Inputs="$(FileVersion);$(AssemblyName)"

0 commit comments

Comments
 (0)