Skip to content

Commit 41da9b3

Browse files
author
TheSnoozer
committed
remove unused argument 'reactorProjects' from GitDirLocator
1 parent 6097668 commit 41da9b3

File tree

3 files changed

+4
-10
lines changed

3 files changed

+4
-10
lines changed

src/main/java/pl/project13/maven/git/GitCommitIdMojo.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1510,7 +1510,7 @@ private void appendPropertiesToReactorProjects(LogInterface log, Properties prop
15101510
* @return the File representation of the .git directory
15111511
*/
15121512
private File lookupGitDirectory() throws GitCommitIdExecutionException {
1513-
return new GitDirLocator(project, reactorProjects).lookupGitDirectory(dotGitDirectory);
1513+
return new GitDirLocator(project).lookupGitDirectory(dotGitDirectory);
15141514
}
15151515

15161516
private void logProperties(LogInterface log, Properties propertiesToPublish) {

src/main/java/pl/project13/maven/git/GitDirLocator.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,18 +35,14 @@
3535
*/
3636
public class GitDirLocator {
3737
final MavenProject mavenProject;
38-
final List<MavenProject> reactorProjects;
3938

4039
/**
4140
* Constructor to encapsulates all references required to locate a valid .git directory
4241
*
4342
* @param mavenProject The currently used (maven) project.
44-
* @param reactorProjects The list of reactor projects (sub-projects) of the current (maven)
45-
* project.
4643
*/
47-
public GitDirLocator(MavenProject mavenProject, List<MavenProject> reactorProjects) {
44+
public GitDirLocator(MavenProject mavenProject) {
4845
this.mavenProject = mavenProject;
49-
this.reactorProjects = reactorProjects;
5046
}
5147

5248
/**

src/test/java/pl/project13/maven/git/GitDirLocatorTest.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,6 @@ public class GitDirLocatorTest {
3737

3838
@Mock MavenProject project;
3939

40-
List<MavenProject> reactorProjects = Collections.emptyList();
41-
4240
@Rule
4341
public TemporaryFolder folder = new TemporaryFolder();
4442

@@ -48,7 +46,7 @@ public void shouldUseTheManuallySpecifiedDirectory() throws Exception {
4846
File dotGitDir = folder.newFolder("temp");
4947
try {
5048
// when
51-
GitDirLocator locator = new GitDirLocator(project, reactorProjects);
49+
GitDirLocator locator = new GitDirLocator(project);
5250
File foundDirectory = locator.lookupGitDirectory(dotGitDir);
5351

5452
// then
@@ -81,7 +79,7 @@ public void shouldResolveRelativeSubmodule() throws Exception {
8179

8280
try {
8381
// when
84-
GitDirLocator locator = new GitDirLocator(project, reactorProjects);
82+
GitDirLocator locator = new GitDirLocator(project);
8583
File foundDirectory = locator.lookupGitDirectory(dotGitDir);
8684

8785
// then

0 commit comments

Comments
 (0)