Improved responsiveness of navbar #315
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @gauravdas014 . There are some conflicts in yarn.lock file. Can you help in resolving them since i have no idea what dependencies(version of them) to be deleted. |
|
@pooja2299 @shashankmotruri will help you out with this. |
shashankmotruri
requested changes
Apr 11, 2021
There was a problem hiding this comment.
@pooja2299 delete yarn.lock and just run yarn again. And do follow contributing guidelines for commit message.
shashankmotruri
requested changes
Apr 15, 2021
There was a problem hiding this comment.
@pooja2299 did u tried yarn ? .I think there are still conflicts with yarn.lock. Try yarn and then yarn install.And if conflits are cleared , do change commit message as mentioned in contributing.md.
|
Yes , i tried yarn . But will try again and resolve conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #288
Description