Merge pull request #63 from gioboa/fix/#62

fix: managed subfolder in baseUrl setting #62

Author: gioboa

src/commands/setup-credentials.ts

@@ -15,14 +15,16 @@ export default async function setupCredentials(): Promise<void> {
   }
 
   // store settings
-  setConfigurationByKey(
-    CONFIG.BASE_URL,
-    await vscode.window.showInputBox({
-      ignoreFocusOut: true,
-      password: false,
-      placeHolder: 'Your Jira url'
-    })
-  );
+  let newBaseUrl = await vscode.window.showInputBox({
+    ignoreFocusOut: true,
+    password: false,
+    placeHolder: 'Your Jira url'
+  });
+  // remove / at the end
+  if (!!newBaseUrl && newBaseUrl.substring(newBaseUrl.length - 1) === '/') {
+    newBaseUrl = newBaseUrl.substring(0, newBaseUrl.length - 1);
+  }
+  setConfigurationByKey(CONFIG.BASE_URL, newBaseUrl);
 
   setConfigurationByKey(
     CONFIG.USERNAME,

src/http/api.ts

@@ -35,10 +35,12 @@ export class Jira implements IJira {
 
     if (this.baseUrl && getGlobalStateConfiguration()) {
       const parsedUrl = url.parse(this.baseUrl);
+      // host from parsedUrl.href because the base url can have subfolder
+      const host = parsedUrl.href.replace(parsedUrl.protocol + '//', '');
       const [username, password] = getGlobalStateConfiguration().split(CREDENTIALS_SEPARATOR);
 
       this.jiraInstance = new jiraClient({
-        host: parsedUrl.host,
+        host: host,
         port: parsedUrl.port,
         protocol: parsedUrl.protocol,
         basic_auth: { username, password }