Skip to content

Commit 96fd6fc

Browse files
committed
refactor(ui-automation): Use resource ids for the Onboarding Screen Tests
PM-89
1 parent 2aea8c9 commit 96fd6fc

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

bank-sdk/example-app/src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/screens/OnboardingScreen.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import androidx.test.espresso.matcher.ViewMatchers.isDisplayed
1010
import org.hamcrest.CoreMatchers.allOf
1111

1212
class OnboardingScreen {
13-
fun checkOnboardingScreenTitle(onboardingTitle: String): OnboardingScreen {
13+
fun checkOnboardingScreenTitle(onboardingTitle: Int): OnboardingScreen {
1414
onView(
1515
allOf(
1616
withId(net.gini.android.capture.R.id.gc_title), withText(onboardingTitle)

bank-sdk/example-app/src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/testcases/OnboardingScreenTests.kt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,14 +46,14 @@ class OnboardingScreenTests {
4646
@Test
4747
fun test1_assertFlatPaperTitle() {
4848
mainScreen.clickPhotoPaymentButton()
49-
onboardingScreen.checkOnboardingScreenTitle("Flat paper within the frame")
49+
onboardingScreen.checkOnboardingScreenTitle(net.gini.android.capture.R.string.gc_onboarding_align_corners_title)
5050
}
5151

5252
@Test
5353
fun test2_clickNextButtonAndAssertGoodLightningTitle() {
5454
mainScreen.clickPhotoPaymentButton()
5555
onboardingScreen.clickNextButton()
56-
onboardingScreen.checkOnboardingScreenTitle("Good lighting")
56+
onboardingScreen.checkOnboardingScreenTitle(net.gini.android.capture.R.string.gc_onboarding_lighting_title)
5757
}
5858

5959
@Test
@@ -62,7 +62,7 @@ class OnboardingScreenTests {
6262
onboardingScreen.clickNextButton()
6363
idlingResource.waitForIdle()
6464
onboardingScreen.clickNextButton()
65-
onboardingScreen.checkOnboardingScreenTitle("Add multiple pages")
65+
onboardingScreen.checkOnboardingScreenTitle(net.gini.android.capture.R.string.gc_onboarding_multipage_title)
6666
}
6767

6868
@Test
@@ -75,7 +75,7 @@ class OnboardingScreenTests {
7575
idlingResource.waitForIdle()
7676
onboardingScreen.clickNextButton()
7777
idlingResource.waitForIdle()
78-
onboardingScreen.checkOnboardingScreenTitle("QR codes supported")
78+
onboardingScreen.checkOnboardingScreenTitle(net.gini.android.capture.R.string.gc_onboarding_qr_code_title)
7979
}
8080

8181
@Test
@@ -102,7 +102,7 @@ class OnboardingScreenTests {
102102
@Test
103103
fun test8a_assertOnboardingOnFirstLaunch() {
104104
mainScreen.clickPhotoPaymentButton()
105-
onboardingScreen.checkOnboardingScreenTitle("Flat paper within the frame")
105+
onboardingScreen.checkOnboardingScreenTitle(net.gini.android.capture.R.string.gc_onboarding_align_corners_title)
106106
onboardingScreen.checkSkipButtonText()
107107
}
108108

0 commit comments

Comments
 (0)