From 22f87d8be1ad98666e33a673f7daa07e9f32965b Mon Sep 17 00:00:00 2001 From: Dima Hutsuliak Date: Mon, 7 Oct 2024 09:37:05 +0200 Subject: [PATCH] Improve naming: pin -> makePinFromRevision() --- Sources/ScipioKit/Producer/Cache/CacheSystem.swift | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/Sources/ScipioKit/Producer/Cache/CacheSystem.swift b/Sources/ScipioKit/Producer/Cache/CacheSystem.swift index 2351fedb..e4badedb 100644 --- a/Sources/ScipioKit/Producer/Cache/CacheSystem.swift +++ b/Sources/ScipioKit/Producer/Cache/CacheSystem.swift @@ -273,7 +273,7 @@ struct CacheSystem: Sendable { private func retrievePin(package: ResolvedPackage) throws -> PinsStore.Pin { #if compiler(>=6.0) - guard let pin = pinsStore.pins[package.identity] ?? package.pin else { + guard let pin = pinsStore.pins[package.identity] ?? package.makePinFromRevision() else { throw Error.revisionNotDetected(package.manifest.displayName) } #elseif swift(>=5.10) @@ -315,9 +315,8 @@ public struct VersionFileDecoder { #if compiler(>=6.0) -fileprivate extension ResolvedPackage { - - var pin: PinsStore.Pin? { +extension ResolvedPackage { + fileprivate func makePinFromRevision() -> PinsStore.Pin? { let repository = GitRepository(path: path) guard let tag = repository.getCurrentTag(), let version = Version(tag: tag) else { @@ -337,7 +336,6 @@ fileprivate extension ResolvedPackage { ) ) } - } #endif