Skip to content

i18n update with header to allow msgfmt -c to be happier (#2314) #43

i18n update with header to allow msgfmt -c to be happier (#2314)

i18n update with header to allow msgfmt -c to be happier (#2314) #43

Triggered via push November 18, 2024 08:04
Status Failure
Total duration 2m 59s
Artifacts
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

php.yml

on: push
Matrix: unit-tests-linux
Matrix: unit-tests-windows
Code coverage
0s
Code coverage
Cleanup artifacts
0s
Cleanup artifacts
Fit to window
Zoom out
Zoom in

Annotations

41 errors and 20 warnings
PossiblyUndefinedArrayOffset: modules/admin/src/Controller/Config.php#L322
modules/admin/src/Controller/Config.php:322:28: PossiblyUndefinedArrayOffset: Possibly undefined array key on array{optional?: string, required?: string} (see https://psalm.dev/167)
RiskyTruthyFalsyComparison: modules/admin/src/Controller/Federation.php#L414
modules/admin/src/Controller/Federation.php:414:19: RiskyTruthyFalsyComparison: Operand of type null|scalar contains type scalar, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
ArgumentTypeCoercion: modules/admin/src/Controller/Federation.php#L415
modules/admin/src/Controller/Federation.php:415:29: ArgumentTypeCoercion: Argument 1 of trim expects string, but parent type non-empty-scalar provided (see https://psalm.dev/193)
PossiblyFalseIterator: modules/admin/src/Controller/Federation.php#L445
modules/admin/src/Controller/Federation.php:445:26: PossiblyFalseIterator: Cannot iterate over falsable var array<array-key, mixed>|false (see https://psalm.dev/164)
ArgumentTypeCoercion: modules/admin/src/Controller/Federation.php#L513
modules/admin/src/Controller/Federation.php:513:50: ArgumentTypeCoercion: Argument 1 of SimpleSAML\Auth\Source::getById expects string, but parent type null|scalar provided (see https://psalm.dev/193)
PossiblyNullArgument: modules/admin/src/Controller/Federation.php#L513
modules/admin/src/Controller/Federation.php:513:50: PossiblyNullArgument: Argument 1 of SimpleSAML\Auth\Source::getById cannot be null, possibly null value provided (see https://psalm.dev/078)
ArgumentTypeCoercion: modules/admin/src/Controller/Federation.php#L517
modules/admin/src/Controller/Federation.php:517:61: ArgumentTypeCoercion: Argument 1 of SimpleSAML\Metadata\MetaDataStorageHandler::getMetaDataConfig expects string, but parent type null|scalar provided (see https://psalm.dev/193)
PossiblyNullArgument: modules/admin/src/Controller/Federation.php#L517
modules/admin/src/Controller/Federation.php:517:61: PossiblyNullArgument: Argument 1 of SimpleSAML\Metadata\MetaDataStorageHandler::getMetaDataConfig cannot be null, possibly null value provided (see https://psalm.dev/078)
ArgumentTypeCoercion: modules/admin/src/Controller/Federation.php#L517
modules/admin/src/Controller/Federation.php:517:72: ArgumentTypeCoercion: Argument 2 of SimpleSAML\Metadata\MetaDataStorageHandler::getMetaDataConfig expects string, but parent type null|scalar provided (see https://psalm.dev/193)
PossiblyNullArgument: modules/admin/src/Controller/Federation.php#L517
modules/admin/src/Controller/Federation.php:517:72: PossiblyNullArgument: Argument 2 of SimpleSAML\Metadata\MetaDataStorageHandler::getMetaDataConfig cannot be null, possibly null value provided (see https://psalm.dev/078)
InvalidPropertyAssignmentValue: tests/modules/core/src/Auth/Process/CardinalitySingleTest.php#L49
tests/modules/core/src/Auth/Process/CardinalitySingleTest.php:49:28: InvalidPropertyAssignmentValue: $this->httpUtils with declared type 'PHPUnit\Framework\MockObject\MockObject|SimpleSAML\Utils\HTTP' cannot be assigned type 'PHPUnit\Framework\MockObject\MockBuilder<SimpleSAML\Utils\HTTP>' (see https://psalm.dev/145)
InvalidPropertyAssignmentValue: tests/modules/core/src/Auth/Process/CardinalityTest.php#L50
tests/modules/core/src/Auth/Process/CardinalityTest.php:50:28: InvalidPropertyAssignmentValue: $this->httpUtils with declared type 'PHPUnit\Framework\MockObject\MockObject|SimpleSAML\Utils\HTTP' cannot be assigned type 'PHPUnit\Framework\MockObject\MockBuilder<SimpleSAML\Utils\HTTP>' (see https://psalm.dev/145)
TypeDoesNotContainNull: tests/modules/core/src/Auth/Process/TargetedIDTest.php#L126
tests/modules/core/src/Auth/Process/TargetedIDTest.php:126:43: TypeDoesNotContainNull: DOMDocument does not contain null (see https://psalm.dev/090)
RedundantCondition: tests/modules/core/src/Auth/Process/TargetedIDTest.php#L126
tests/modules/core/src/Auth/Process/TargetedIDTest.php:126:43: RedundantCondition: Type DOMDocument for $__tmp_nullsafe__3573 is never null (see https://psalm.dev/122)
UndefinedDocblockClass: tests/modules/saml/src/Auth/Source/SPTest.php#L123
tests/modules/saml/src/Auth/Source/SPTest.php:123:16: UndefinedDocblockClass: Docblock-defined class, interface or enum named SimpleSAML\SAML2\AuthnRequest does not exist (see https://psalm.dev/200)
UndefinedDocblockClass: tests/modules/saml/src/Auth/Source/SPTest.php#L150
tests/modules/saml/src/Auth/Source/SPTest.php:150:16: UndefinedDocblockClass: Docblock-defined class, interface or enum named SimpleSAML\SAML2\LogoutRequest does not exist (see https://psalm.dev/200)
UndefinedDocblockClass: tests/modules/saml/src/Auth/Source/SPTest.php#L178
tests/modules/saml/src/Auth/Source/SPTest.php:178:16: UndefinedDocblockClass: Docblock-defined class, interface or enum named SimpleSAML\SAML2\AuthnRequest does not exist (see https://psalm.dev/200)
UndefinedPropertyFetch: tests/modules/saml/src/Auth/Source/SPTest.php#L191
tests/modules/saml/src/Auth/Source/SPTest.php:191:13: UndefinedPropertyFetch: Instance property DOMNameSpaceNode::$textContent is not defined (see https://psalm.dev/039)
UndefinedDocblockClass: tests/modules/saml/src/Auth/Source/SPTest.php#L208
tests/modules/saml/src/Auth/Source/SPTest.php:208:19: UndefinedDocblockClass: Docblock-defined class, interface or enum named SimpleSAML\SAML2\AuthnRequest does not exist (see https://psalm.dev/200)
UndefinedDocblockClass: tests/modules/saml/src/Auth/Source/SPTest.php#L212
tests/modules/saml/src/Auth/Source/SPTest.php:212:16: UndefinedDocblockClass: Docblock-defined class, interface or enum named SimpleSAML\SAML2\AuthnRequest does not exist (see https://psalm.dev/200)
Quality control
Process completed with exit code 1.
Quality control
Process completed with exit code 1.
Unit tests, PHP 8.1, ubuntu-latest: tests/src/SimpleSAML/Locale/LanguageTest.php#L57
Failed asserting that null matches expected 'es'.
Unit tests, PHP 8.1, ubuntu-latest: tests/src/SimpleSAML/Metadata/MetaDataStorageHandlerTest.php#L265
Failed asserting that two strings are identical.
Unit tests, PHP 8.1, ubuntu-latest
Process completed with exit code 2.
Unit tests, PHP 8.2, ubuntu-latest: tests/src/SimpleSAML/Locale/LanguageTest.php#L57
Failed asserting that null matches expected 'es'.
Unit tests, PHP 8.2, ubuntu-latest: tests/src/SimpleSAML/Metadata/MetaDataStorageHandlerTest.php#L259
Failed asserting that two strings are identical.
Unit tests, PHP 8.2, ubuntu-latest
Process completed with exit code 2.
Unit tests, PHP 8.3, ubuntu-latest: tests/src/SimpleSAML/Locale/LanguageTest.php#L57
Failed asserting that null matches expected 'es'.
Unit tests, PHP 8.3, ubuntu-latest: tests/src/SimpleSAML/Metadata/MetaDataStorageHandlerTest.php#L259
Failed asserting that two strings are identical.
Unit tests, PHP 8.3, ubuntu-latest
Process completed with exit code 2.
Unit tests, PHP 8.1, windows-latest: tests/src/SimpleSAML/Locale/LanguageTest.php#L57
Failed asserting that null matches expected 'es'.
Unit tests, PHP 8.1, windows-latest
Process completed with exit code 1.
Unit tests, PHP 8.3, windows-latest: tests/src/SimpleSAML/Locale/LanguageTest.php#L57
Failed asserting that null matches expected 'es'.
Unit tests, PHP 8.3, windows-latest
Process completed with exit code 1.
Unit tests, PHP 8.2, windows-latest
The job was canceled because "windows-latest_8_3" failed.
Unit tests, PHP 8.2, windows-latest: tests/src/SimpleSAML/Locale/LanguageTest.php#L57
Failed asserting that null matches expected 'es'.
Unit tests, PHP 8.2, windows-latest
Process completed with exit code 1.
MissingClassConstType: modules/admin/src/Controller/Config.php#L33
modules/admin/src/Controller/Config.php:33:18: MissingClassConstType: Class constant "SimpleSAML\Module\admin\Controller\Config::LATEST_VERSION_STATE_KEY" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: modules/admin/src/Controller/Config.php#L35
modules/admin/src/Controller/Config.php:35:18: MissingClassConstType: Class constant "SimpleSAML\Module\admin\Controller\Config::RELEASES_API" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: modules/core/src/Auth/Source/RequestedAuthnContextSelector.php#L27
modules/core/src/Auth/Source/RequestedAuthnContextSelector.php:27:18: MissingClassConstType: Class constant "SimpleSAML\Module\core\Auth\Source\RequestedAuthnContextSelector::AUTHID" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: modules/core/src/Auth/Source/RequestedAuthnContextSelector.php#L32
modules/core/src/Auth/Source/RequestedAuthnContextSelector.php:32:18: MissingClassConstType: Class constant "SimpleSAML\Module\core\Auth\Source\RequestedAuthnContextSelector::STAGEID" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: modules/core/src/Auth/Source/RequestedAuthnContextSelector.php#L37
modules/core/src/Auth/Source/RequestedAuthnContextSelector.php:37:18: MissingClassConstType: Class constant "SimpleSAML\Module\core\Auth\Source\RequestedAuthnContextSelector::SOURCESID" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: modules/core/src/Auth/Source/SourceIPSelector.php#L25
modules/core/src/Auth/Source/SourceIPSelector.php:25:18: MissingClassConstType: Class constant "SimpleSAML\Module\core\Auth\Source\SourceIPSelector::AUTHID" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: modules/core/src/Auth/Source/SourceIPSelector.php#L30
modules/core/src/Auth/Source/SourceIPSelector.php:30:18: MissingClassConstType: Class constant "SimpleSAML\Module\core\Auth\Source\SourceIPSelector::STAGEID" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: modules/core/src/Auth/Source/SourceIPSelector.php#L35
modules/core/src/Auth/Source/SourceIPSelector.php:35:18: MissingClassConstType: Class constant "SimpleSAML\Module\core\Auth\Source\SourceIPSelector::SOURCESID" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: modules/core/src/Auth/UserPassBase.php#L26
modules/core/src/Auth/UserPassBase.php:26:18: MissingClassConstType: Class constant "SimpleSAML\Module\core\Auth\UserPassBase::STAGEID" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: modules/core/src/Auth/UserPassBase.php#L31
modules/core/src/Auth/UserPassBase.php:31:18: MissingClassConstType: Class constant "SimpleSAML\Module\core\Auth\UserPassBase::AUTHID" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: tests/SigningTestCase.php#L169
tests/SigningTestCase.php:169:21: MissingClassConstType: Class constant "SimpleSAML\Test\SigningTestCase::ROOTDIRNAME" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: tests/SigningTestCase.php#L170
tests/SigningTestCase.php:170:21: MissingClassConstType: Class constant "SimpleSAML\Test\SigningTestCase::DEFAULTCERTDIR" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: tests/SigningTestCase.php#L171
tests/SigningTestCase.php:171:21: MissingClassConstType: Class constant "SimpleSAML\Test\SigningTestCase::CA_PRIVATE_KEY" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: tests/SigningTestCase.php#L172
tests/SigningTestCase.php:172:21: MissingClassConstType: Class constant "SimpleSAML\Test\SigningTestCase::CA_CERTIFICATE" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: tests/SigningTestCase.php#L173
tests/SigningTestCase.php:173:21: MissingClassConstType: Class constant "SimpleSAML\Test\SigningTestCase::GOOD_PRIVATE_KEY" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: tests/SigningTestCase.php#L174
tests/SigningTestCase.php:174:21: MissingClassConstType: Class constant "SimpleSAML\Test\SigningTestCase::GOOD_CERTIFICATE" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: tests/modules/admin/src/Controller/FederationTest.php#L28
tests/modules/admin/src/Controller/FederationTest.php:28:19: MissingClassConstType: Class constant "SimpleSAML\Test\Module\admin\Controller\FederationTest::SECURITY" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: tests/modules/admin/src/Controller/FederationTest.php#L31
tests/modules/admin/src/Controller/FederationTest.php:31:19: MissingClassConstType: Class constant "SimpleSAML\Test\Module\admin\Controller\FederationTest::FRAMEWORK" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: tests/modules/admin/src/Controller/FederationTest.php#L34
tests/modules/admin/src/Controller/FederationTest.php:34:19: MissingClassConstType: Class constant "SimpleSAML\Test\Module\admin\Controller\FederationTest::LIBRARY" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: tests/modules/admin/src/Controller/FederationTest.php#L37
tests/modules/admin/src/Controller/FederationTest.php:37:18: MissingClassConstType: Class constant "SimpleSAML\Test\Module\admin\Controller\FederationTest::CERT_KEY" should have a declared type. (see https://psalm.dev/359)