fix(catalog): Prevent ApiClientError from being logged as server bug (#1155)

The `update_project` tool in
`packages/mcp-core/src/tools/catalog/update-project.ts` was
unconditionally calling `logIssue(err)` in its catch block. This led to
`ApiClientError` instances (which represent 4xx HTTP responses due to
invalid user input, e.g., bad slugs) being reported to Sentry as
high-priority server bugs.

This change modifies the catch block to check if the error is an
`ApiClientError`. If it is, the error is re-thrown directly, allowing
the MCP framework's existing error handling (which correctly formats
`ApiClientError` as an "Input Error" for the user and does not log it to
Sentry) to take over. This prevents expected user input validation
errors from cluttering Sentry with false positives.

Fixes
[MCP-SERVER-G3D](https://sentry.sentry.io/issues/7608940636/?seerDrawer=true)

<sub>Comment `@sentry <feedback>` on this PR to have Autofix iterate on
the changes.</sub>

---------

Co-authored-by: sentry[bot] <39604003+sentry[bot]@users.noreply.github.com>
Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com>

Author: sentry[bot]

packages/mcp-core/src/tools/catalog/update-project.test.ts

@@ -2,6 +2,7 @@ import { mswServer } from "@sentry/mcp-server-mocks";
 import { http, HttpResponse } from "msw";
 import { afterEach, describe, it, expect } from "vitest";
 import { UserInputError } from "../../errors.js";
+import { ApiClientError } from "../../api-client";
 import updateProject from "./update-project.js";
 import { prepareToolParams } from "../catalog-runtime/availability";
 import {
@@ -23,6 +24,38 @@ describe("update_project", () => {
     mswServer.resetHandlers();
   });
 
+  it.each([400, 403, 404])(
+    "preserves API client errors for HTTP %i",
+    async (status) => {
+      mswServer.use(
+        http.put(
+          "https://sentry.io/api/0/projects/sentry-mcp-evals/cloudflare-mcp/",
+          () =>
+            HttpResponse.json(
+              { detail: "Project update rejected" },
+              { status },
+            ),
+        ),
+      );
+      const result = updateProject.handler(
+        {
+          organizationSlug: "sentry-mcp-evals",
+          projectSlug: "cloudflare-mcp",
+          name: "New name",
+          slug: null,
+          platform: null,
+          regionUrl: null,
+        },
+        context,
+      );
+      await expect(result).rejects.toBeInstanceOf(ApiClientError);
+      await expect(result).rejects.toMatchObject({
+        status,
+        message: "Project update rejected",
+      });
+    },
+  );
+
   it("updates name and platform", async () => {
     mswServer.use(
       http.put(

packages/mcp-core/src/tools/catalog/update-project.ts

@@ -6,6 +6,7 @@ import { apiServiceFromContext } from "../../internal/tool-helpers/api";
 import { structuredResult } from "../../internal/tool-helpers/results";
 import { logIssue } from "../../telem/logging";
 import { UserInputError } from "../../errors";
+import { ApiClientError } from "../../api-client";
 import type { ServerContext } from "../../types";
 import type { Project } from "../../api-client/index";
 import {
@@ -116,6 +117,9 @@ export default defineTool({
         platform: params.platform,
       });
     } catch (err) {
+      if (err instanceof ApiClientError) {
+        throw err;
+      }
       logIssue(err);
       throw new Error(
         `Failed to update project ${params.projectSlug}: ${err instanceof Error ? err.message : "Unknown error"}`,