Repository navigation
Commit cb83fe1
fix(api): accept null legacy event context (#1353)
Event responses can contain `context: null` for legacy extra data. MCP
rejected those responses before `get_issue_details` could return the
event's error and stacktrace.
Accept null in the shared event schema, preserve validation for records
and other fields, and keep the existing formatter behavior that omits
empty extra data. Regression tests cover the API client and
issue-details handler, including safe diagnostics for other validation
failures.
## Validation
- Both regressions fail before the fix and pass afterward; 113 focused
tests pass.
- `pnpm run tsc` and `pnpm run lint` pass.
- `pnpm run test` passes in Linux x64 with Node 24 and UTC.
- Documentation links and workspace CI selector tests pass.
- The packed stdio package installs in a clean consumer; typecheck and
runtime import pass.
The documentation update selects all workspace projects in CI,
exercising the monorepo build and package checks.
CI: all builds, MCP tests, CLI unit/E2E tests, CLI package/runtime
checks, and the clean stdio consumer pass. The CLI and CLI docs jobs
fail only their generated-file checks: the existing period-help
generator uses the current month in examples, changing ten generated
references. That date-dependent output is separate from this
event-schema fix.
Co-authored-by: Codex (GPT-6) <noreply@openai.com>1 parent 3ef57b5 commit cb83fe1
4 files changed
Lines changed: 40 additions & 2 deletions
File tree
- docs/contributing
- packages/mcp-core/src
- api-client
- tools/catalog
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
125 | 125 | | |
126 | 126 | | |
127 | 127 | | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
128 | 132 | | |
129 | 133 | | |
130 | 134 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
37 | 36 | | |
38 | 37 | | |
39 | 38 | | |
40 | 39 | | |
41 | 40 | | |
| 41 | + | |
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| |||
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
| 71 | + | |
71 | 72 | | |
72 | 73 | | |
73 | 74 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1133 | 1133 | | |
1134 | 1134 | | |
1135 | 1135 | | |
1136 | | - | |
| 1136 | + | |
| 1137 | + | |
1137 | 1138 | | |
1138 | 1139 | | |
1139 | 1140 | | |
| |||
Lines changed: 32 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
| |||
2055 | 2056 | | |
2056 | 2057 | | |
2057 | 2058 | | |
| 2059 | + | |
| 2060 | + | |
| 2061 | + | |
| 2062 | + | |
| 2063 | + | |
| 2064 | + | |
| 2065 | + | |
| 2066 | + | |
| 2067 | + | |
| 2068 | + | |
| 2069 | + | |
| 2070 | + | |
| 2071 | + | |
| 2072 | + | |
| 2073 | + | |
| 2074 | + | |
| 2075 | + | |
| 2076 | + | |
| 2077 | + | |
| 2078 | + | |
| 2079 | + | |
| 2080 | + | |
| 2081 | + | |
| 2082 | + | |
| 2083 | + | |
| 2084 | + | |
| 2085 | + | |
| 2086 | + | |
| 2087 | + | |
| 2088 | + | |
| 2089 | + | |
2058 | 2090 | | |
2059 | 2091 | | |
2060 | 2092 | | |
| |||
0 commit comments