chore(lint): Enable type-aware Oxlint rules disabled in #1556

Turn the nine type-aware rules back on and fix the violations they
report: drop awaits on non-thenables, mark intentional fire-and-forget
promises with void, await forgotten assertions, give sorts explicit
comparators, stop stringifying unknown values to "[object Object]", and
remove redundant type constituents.

no-floating-promises allows node:test's test/describe helpers,
restrict-template-expressions allows never, and unbound-method stays off
in tests, where mock and identity assertions trip it.

Fixes #1573

Co-Authored-By: BYK <burak.kaya@sentry.io>

Author: sentry-junior[bot]

.github/tests/pr-risk-labels.test.mjs

@@ -119,7 +119,10 @@ for (const risk of ["low", "medium", "high"]) {
       },
       async ({ run, labels }) => {
         await run();
-        assert.deepEqual([...labels].sort(), ["area: auth", `risk: ${risk}`]);
+        assert.deepEqual(
+          [...labels].sort((a, b) => a.localeCompare(b)),
+          ["area: auth", `risk: ${risk}`],
+        );
       },
     );
   });

.oxlintrc.json

@@ -20,18 +20,33 @@
   "rules": {
     "no-unused-vars": "off",
     "typescript/return-await": ["error", "always"],
-    "typescript/await-thenable": "off",
-    "typescript/no-base-to-string": "off",
-    "typescript/no-duplicate-type-constituents": "off",
-    "typescript/no-floating-promises": "off",
-    "typescript/no-misused-spread": "off",
-    "typescript/no-redundant-type-constituents": "off",
-    "typescript/require-array-sort-compare": "off",
-    "typescript/restrict-template-expressions": "off",
-    "typescript/unbound-method": "off",
+    "typescript/no-floating-promises": [
+      "error",
+      {
+        "allowForKnownSafeCalls": [
+          {
+            "from": "package",
+            "package": "node:test",
+            "name": ["test", "it", "describe", "suite"]
+          }
+        ]
+      }
+    ],
+    "typescript/restrict-template-expressions": [
+      "error",
+      {
+        "allowNever": true
+      }
+    ],
     "jsx-a11y/interactive-supports-focus": "off"
   },
   "overrides": [
+    {
+      "files": ["**/*.test.{ts,tsx,mjs}", "**/test/**/*.{ts,tsx}"],
+      "rules": {
+        "typescript/unbound-method": "off"
+      }
+    },
     {
       "files": ["packages/mcp-cloudflare/src/client/**/*.tsx"],
       "rules": {

packages/cli/script/build.ts

@@ -418,7 +418,7 @@ async function compileAllTargets(
       successes += 1;
     } catch (error) {
       console.error(
-        `  Post-processing ${getPackageName(target)} failed: ${error}`,
+        `  Post-processing ${getPackageName(target)} failed: ${String(error)}`,
       );
       failures += 1;
     }

packages/cli/src/commands/alert/issues/create.ts

@@ -11,7 +11,11 @@ import {
 } from "../../../lib/api-client.js";
 import { parseOrgProjectArg } from "../../../lib/arg-parsing.js";
 import { buildCommand, numberParser } from "../../../lib/command.js";
-import { ContextError, ValidationError } from "../../../lib/errors.js";
+import {
+  ContextError,
+  stringifyUnknown,
+  ValidationError,
+} from "../../../lib/errors.js";
 import { CommandOutput } from "../../../lib/formatters/output.js";
 import { DRY_RUN_ALIASES, DRY_RUN_FLAG } from "../../../lib/mutate-command.js";
 import { resolveProjectBoundTargets } from "../../../lib/resolve-target.js";
@@ -244,9 +248,9 @@ export const createCommand = buildCommand({
     yield new CommandOutput({
       org: target.org,
       project: target.project,
-      id: String(created.id ?? ""),
-      name: String(created.name ?? flags.name),
-      status: String(
+      id: stringifyUnknown(created.id ?? ""),
+      name: stringifyUnknown(created.name ?? flags.name),
+      status: stringifyUnknown(
         created.status ?? (created.enabled === false ? "disabled" : "active"),
       ),
     } satisfies CreateResult);

packages/cli/src/commands/alert/issues/edit.ts

@@ -12,7 +12,11 @@ import {
 } from "../../../lib/api-client.js";
 import { parseOrgProjectArg } from "../../../lib/arg-parsing.js";
 import { buildCommand, numberParser } from "../../../lib/command.js";
-import { ContextError, ValidationError } from "../../../lib/errors.js";
+import {
+  ContextError,
+  stringifyUnknown,
+  ValidationError,
+} from "../../../lib/errors.js";
 import { CommandOutput } from "../../../lib/formatters/output.js";
 import { resolveProjectBoundTargets } from "../../../lib/resolve-target.js";
 import {
@@ -284,10 +288,10 @@ export const editCommand = buildCommand({
       ...updated,
       org: target.org,
       project: target.project,
-      id: String(updated.id ?? rule.id),
+      id: stringifyUnknown(updated.id ?? rule.id),
       // The workflows endpoint returns `enabled` rather than `status`; map it
       // back to a status label so human/JSON output matches the create path.
-      status: String(
+      status: stringifyUnknown(
         updated.status ?? (updated.enabled === false ? "disabled" : "active"),
       ),
     } satisfies EditResult);

packages/cli/src/commands/alert/issues/rule-resolve.ts

@@ -42,7 +42,7 @@ export function parseIssueRuleArg(
     );
   }
 
-  const slashCount = [...trimmed].filter((c) => c === "/").length;
+  const slashCount = trimmed.split("/").length - 1;
   if (slashCount === 0) {
     return { ref: trimmed, targetArg: undefined };
   }

packages/cli/src/commands/alert/metrics/create.ts

@@ -7,7 +7,7 @@
 import type { SentryContext } from "../../../context.js";
 import { createMetricAlertRule } from "../../../lib/api-client.js";
 import { buildCommand, numberParser } from "../../../lib/command.js";
-import { ValidationError } from "../../../lib/errors.js";
+import { stringifyUnknown, ValidationError } from "../../../lib/errors.js";
 import { warning } from "../../../lib/formatters/colors.js";
 import { CommandOutput } from "../../../lib/formatters/output.js";
 import { DRY_RUN_ALIASES, DRY_RUN_FLAG } from "../../../lib/mutate-command.js";
@@ -222,8 +222,8 @@ export const createCommand = buildCommand({
     const created = await createMetricAlertRule(orgSlug, body);
     yield new CommandOutput({
       org: orgSlug,
-      id: String(created.id ?? ""),
-      name: String(created.name ?? flags.name),
+      id: stringifyUnknown(created.id ?? ""),
+      name: stringifyUnknown(created.name ?? flags.name),
       status: metricAlertStatusLabel(created.status),
     } satisfies CreateResult);
   },

packages/cli/src/commands/alert/metrics/edit.ts

@@ -10,7 +10,7 @@ import {
   putMetricAlertRule,
 } from "../../../lib/api-client.js";
 import { buildCommand, numberParser } from "../../../lib/command.js";
-import { ValidationError } from "../../../lib/errors.js";
+import { stringifyUnknown, ValidationError } from "../../../lib/errors.js";
 import { warning } from "../../../lib/formatters/colors.js";
 import { CommandOutput } from "../../../lib/formatters/output.js";
 import { resolveOrgOnlyFromArg } from "../../../lib/resolve-target.js";
@@ -290,7 +290,7 @@ export const editCommand = buildCommand({
     yield new CommandOutput({
       ...updated,
       org: orgSlug,
-      id: String(updated.id ?? rule.id),
+      id: stringifyUnknown(updated.id ?? rule.id),
       status: metricAlertStatusLabel(updated.status),
     } satisfies EditResult);
   },

packages/cli/src/commands/alert/metrics/rule-resolve.ts

@@ -45,7 +45,7 @@ export function parseMetricRuleArg(
     return { ref: trimmed, targetArg: undefined };
   }
 
-  const slashCount = [...trimmed].filter((c) => c === "/").length;
+  const slashCount = trimmed.split("/").length - 1;
   if (slashCount > 1) {
     throw new ValidationError(
       `Metric alerts are org-scoped — use '<org>/<rule-id-or-name>', not '<org>/<project>/<rule>'.\nUse: ${usageHint}`,

packages/cli/src/commands/api.ts

@@ -11,7 +11,11 @@ import * as Sentry from "@sentry/node-core/light";
 import type { SentryContext } from "../context.js";
 import { appendSearchParams, rawApiRequest } from "../lib/api-client.js";
 import { buildCommand } from "../lib/command.js";
-import { OutputError, ValidationError } from "../lib/errors.js";
+import {
+  OutputError,
+  stringifyUnknown,
+  ValidationError,
+} from "../lib/errors.js";
 import { filterFields } from "../lib/formatters/json.js";
 import { CommandOutput } from "../lib/formatters/output.js";
 import { validateEndpoint } from "../lib/input-validation.js";
@@ -1071,7 +1075,7 @@ export function formatApiResponse(data: unknown): string {
   if (typeof data === "object") {
     return JSON.stringify(data, null, 2);
   }
-  return String(data);
+  return stringifyUnknown(data);
 }
 
 /**