Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling of errors when using the tracing tool in snuba-admin #6684

Closed
phacops opened this issue Dec 17, 2024 · 1 comment · Fixed by #6763
Closed

Better handling of errors when using the tracing tool in snuba-admin #6684

phacops opened this issue Dec 17, 2024 · 1 comment · Fixed by #6763
Assignees
@kylemumma

Comments

@phacops
Copy link
Contributor

phacops commented Dec 17, 2024

When using the tracing tool, queries can return an error. Right now, it's either returned in a JavaScript alerts or not returned at all and we frequently have to open the developer tools of our browser to reach for the failed HTTP request body and actually look at the error that was returned.

We should surface the error in a better way than JavaScript alerts and make sure they are displayed every time, whether it's a ClickHouse error message or an HTTP failure due to a timeout.
@onkar onkar mentioned this issue Jan 15, 2025
Merged
@onkar
Copy link
Member

onkar commented Jan 15, 2025

Resolving because the PR is merged.

@onkar onkar closed this as completed Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kylemumma kylemumma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: snuba admin system query error messaging getsentry/snuba
3 participants
@onkar @phacops @kylemumma