bug(sampling-in-storage): empty config should not do storage routing (#7007)

getsentry/eap-planning#230

Co-authored-by: Rachel Chen <[email protected]>

Author: xurui-c

snuba/web/rpc/v1/resolvers/R_eap_spans/common/sampling_in_storage_util.py

@@ -128,7 +128,11 @@ def run_query_to_correct_tier(
     build_query: Callable[[T], Query],
     metrics_backend: MetricsBackend,
 ) -> QueryResult:
-    if not in_msg.meta.HasField("downsampled_storage_config"):
+    if (
+        not in_msg.meta.HasField("downsampled_storage_config")
+        or in_msg.meta.downsampled_storage_config.mode
+        == DownsampledStorageConfig.MODE_UNSPECIFIED
+    ):
         return run_query(
             dataset=PluggableDataset(name="eap", all_entities=[]),
             request=build_snuba_request(in_msg, query_settings, build_query),

tests/web/rpc/v1/test_endpoint_trace_item_table/test_endpoint_trace_item_table.py

@@ -3205,6 +3205,43 @@ def use_eap_items_table(
         snuba_set_config("use_eap_items_table", True)
         snuba_set_config("use_eap_items_table_start_timestamp_seconds", 0)
 
+    def test_empty_downsampling_storage_config_does_not_have_downsampled_storage_meta(
+        self,
+    ) -> None:
+        items_storage = get_storage(StorageKey("eap_items"))
+        msg_timestamp = BASE_TIME - timedelta(minutes=1)
+        messages = [
+            gen_message(
+                msg_timestamp,
+            )
+            for _ in range(30)
+        ]
+        write_raw_unprocessed_events(items_storage, messages)  # type: ignore
+
+        ts = Timestamp(seconds=int(BASE_TIME.timestamp()))
+        hour_ago = int((BASE_TIME - timedelta(hours=1)).timestamp())
+
+        empty_downsampled_storage_config_message = TraceItemTableRequest(
+            meta=RequestMeta(
+                project_ids=[1, 2, 3],
+                organization_id=1,
+                cogs_category="something",
+                referrer="something",
+                start_timestamp=Timestamp(seconds=hour_ago),
+                end_timestamp=ts,
+                request_id="be3123b3-2e5d-4eb9-bb48-f38eaa9e8480",
+                trace_item_type=TraceItemType.TRACE_ITEM_TYPE_SPAN,
+                downsampled_storage_config=DownsampledStorageConfig(),
+            ),
+            columns=[
+                Column(key=AttributeKey(type=AttributeKey.TYPE_STRING, name="color"))
+            ],
+        )
+        response = EndpointTraceItemTable().execute(
+            empty_downsampled_storage_config_message
+        )
+        assert not response.meta.HasField("downsampled_storage_meta")
+
     def test_preflight(self) -> None:
         items_storage = get_storage(StorageKey("eap_items"))
         msg_timestamp = BASE_TIME - timedelta(minutes=1)