From 31bbe1ca27e7502506723566603a53fd058266a6 Mon Sep 17 00:00:00 2001
From: Ryan Albrecht <ryan.albrecht@sentry.io>
Date: Sun, 19 Jul 2026 19:55:27 +0000
Subject: [PATCH] fix(dashboards): Resolve static-component-definitions in
 GenericFilterSelector

---
 .../globalFilter/genericFilterSelector.tsx    | 28 ++++++-------------
 1 file changed, 9 insertions(+), 19 deletions(-)

diff --git a/static/app/views/dashboards/globalFilter/genericFilterSelector.tsx b/static/app/views/dashboards/globalFilter/genericFilterSelector.tsx
index da5020fdddb9..14eee76dd49f 100644
--- a/static/app/views/dashboards/globalFilter/genericFilterSelector.tsx
+++ b/static/app/views/dashboards/globalFilter/genericFilterSelector.tsx
@@ -13,27 +13,17 @@ export type GenericFilterSelectorProps = {
   disableRemoveFilter?: boolean;
 };
 
-function getFilterSelector(
-  globalFilter: GlobalFilter
-): React.ComponentType<GenericFilterSelectorProps> {
-  const fieldDefinition = getFieldDefinitionForDataset(
-    globalFilter.tag,
-    globalFilter.dataset
-  );
-  switch (fieldDefinition?.valueType) {
-    case FieldValueType.NUMBER:
-    case FieldValueType.DURATION:
-      return NumericFilterSelector;
-    case FieldValueType.STRING:
-    default:
-      return FilterSelector;
-  }
-}
-
 export function GenericFilterSelector({
   globalFilter,
   ...props
 }: GenericFilterSelectorProps) {
-  const FilterSelectorForType = getFilterSelector(globalFilter);
-  return <FilterSelectorForType globalFilter={globalFilter} {...props} />;
+  const fieldDefinition = getFieldDefinitionForDataset(
+    globalFilter.tag,
+    globalFilter.dataset
+  );
+  const isNumericType =
+    fieldDefinition?.valueType === FieldValueType.NUMBER ||
+    fieldDefinition?.valueType === FieldValueType.DURATION;
+  const Component = isNumericType ? NumericFilterSelector : FilterSelector;
+  return <Component globalFilter={globalFilter} {...props} />;
 }