From b4f39b9db49f39c7c75ba64663302ddc50650cf9 Mon Sep 17 00:00:00 2001 From: Amy Chen Date: Fri, 12 Jun 2026 14:22:18 -0700 Subject: [PATCH 1/2] removing dropped counts from snuba queries --- .../organization_report_context_factory.py | 37 ++++--------------- src/sentry/tasks/summaries/utils.py | 16 ++------ 2 files changed, 12 insertions(+), 41 deletions(-) diff --git a/src/sentry/tasks/summaries/organization_report_context_factory.py b/src/sentry/tasks/summaries/organization_report_context_factory.py index f8c1d8cd7f65..e6fd0a5f46cb 100644 --- a/src/sentry/tasks/summaries/organization_report_context_factory.py +++ b/src/sentry/tasks/summaries/organization_report_context_factory.py @@ -68,37 +68,16 @@ def _append_project_event_counts(self, ctx: OrganizationReportContext) -> None: total = data["total"] timestamp = int(parse_snuba_datetime(data["time"]).timestamp()) if data["category"] == DataCategory.TRANSACTION: - # Transaction outcome - if ( - data["outcome"] == Outcome.RATE_LIMITED - or data["outcome"] == Outcome.FILTERED - ): - project_ctx.dropped_transaction_count += total - else: - project_ctx.accepted_transaction_count += total - project_ctx.transaction_count_by_day[timestamp] = total + project_ctx.accepted_transaction_count += total + project_ctx.transaction_count_by_day[timestamp] = total elif data["category"] == DataCategory.REPLAY: - # Replay outcome - if ( - data["outcome"] == Outcome.RATE_LIMITED - or data["outcome"] == Outcome.FILTERED - ): - project_ctx.dropped_replay_count += total - else: - project_ctx.accepted_replay_count += total - project_ctx.replay_count_by_day[timestamp] = total + project_ctx.accepted_replay_count += total + project_ctx.replay_count_by_day[timestamp] = total else: - # Error outcome - if ( - data["outcome"] == Outcome.RATE_LIMITED - or data["outcome"] == Outcome.FILTERED - ): - project_ctx.dropped_error_count += total - else: - project_ctx.accepted_error_count += total - project_ctx.error_count_by_day[timestamp] = ( - project_ctx.error_count_by_day.get(timestamp, 0) + total - ) + project_ctx.accepted_error_count += total + project_ctx.error_count_by_day[timestamp] = ( + project_ctx.error_count_by_day.get(timestamp, 0) + total + ) @metrics.wraps("weekly_report.create_context.project_event_counts_previous_week") def _append_project_event_counts_previous_week(self, ctx: OrganizationReportContext) -> None: diff --git a/src/sentry/tasks/summaries/utils.py b/src/sentry/tasks/summaries/utils.py index 7c3bf05f27b7..124153de1b83 100644 --- a/src/sentry/tasks/summaries/utils.py +++ b/src/sentry/tasks/summaries/utils.py @@ -68,11 +68,8 @@ def is_empty(self): class ProjectContext: accepted_error_count = 0 - dropped_error_count = 0 accepted_transaction_count = 0 - dropped_transaction_count = 0 accepted_replay_count = 0 - dropped_replay_count = 0 prev_week_accepted_error_count = 0 prev_week_accepted_transaction_count = 0 @@ -106,9 +103,9 @@ def __repr__(self) -> str: return "\n".join( [ f"{self.key_errors_by_group}, ", - f"Errors: [Accepted {self.accepted_error_count}, Dropped {self.dropped_error_count}]", - f"Transactions: [Accepted {self.accepted_transaction_count} Dropped {self.dropped_transaction_count}]", - f"Replays: [Accepted {self.accepted_replay_count} Dropped {self.dropped_replay_count}]", + f"Errors: [Accepted {self.accepted_error_count}]", + f"Transactions: [Accepted {self.accepted_transaction_count}]", + f"Replays: [Accepted {self.accepted_replay_count}]", ] ) @@ -118,11 +115,8 @@ def check_if_project_is_empty(self): and not self.key_transactions and not self.key_performance_issues and not self.accepted_error_count - and not self.dropped_error_count and not self.accepted_transaction_count - and not self.dropped_transaction_count and not self.accepted_replay_count - and not self.dropped_replay_count ) @@ -704,9 +698,7 @@ def project_event_counts_for_organization(start, end, ctx, referrer: str) -> lis Condition(Column("timestamp"), Op.GTE, start), Condition(Column("timestamp"), Op.LT, end + timedelta(days=1)), Condition(Column("org_id"), Op.EQ, ctx.organization.id), - Condition( - Column("outcome"), Op.IN, [Outcome.ACCEPTED, Outcome.FILTERED, Outcome.RATE_LIMITED] - ), + Condition(Column("outcome"), Op.EQ, Outcome.ACCEPTED), Condition( Column("category"), Op.IN, From ead7687481208d4422d53d8f7cdd46dbafa1e8aa Mon Sep 17 00:00:00 2001 From: Amy Chen Date: Fri, 12 Jun 2026 14:37:21 -0700 Subject: [PATCH 2/2] fixing typing errors by removing dropped counts from the debug view --- src/sentry/web/frontend/debug/debug_weekly_report.py | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/sentry/web/frontend/debug/debug_weekly_report.py b/src/sentry/web/frontend/debug/debug_weekly_report.py index 65fcad1f424d..4ab8d08051ff 100644 --- a/src/sentry/web/frontend/debug/debug_weekly_report.py +++ b/src/sentry/web/frontend/debug/debug_weekly_report.py @@ -81,15 +81,6 @@ def get_context(self, request): project_context.accepted_replay_count = sum( project_context.replay_count_by_day.values() ) - project_context.dropped_error_count = int( - random.weibullvariate(5, 1) * random.paretovariate(0.2) - ) - project_context.dropped_transaction_count = int( - random.weibullvariate(5, 1) * random.paretovariate(0.2) - ) - project_context.dropped_replay_count = int( - random.weibullvariate(5, 1) * random.paretovariate(0.2) - ) project_context.prev_week_accepted_error_count = int( project_context.accepted_error_count * random.uniform(0.5, 1.5) )