Skip to content

ref(replays): cut two type-only edges into the import cycle #117031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoshuaKGoldberg merged 4 commits into from
Jun 8, 2026
Merged

ref(replays): cut two type-only edges into the import cycle #117031

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce5c05b
ref(replays): cut two type-only edges into the import cycle
JoshuaKGoldberg Jun 5, 2026
b16a69a
Remove re-export
JoshuaKGoldberg Jun 8, 2026
a63fbb2
:hammer_and_wrench: apply pre-commit fixes
getsantry[bot] Jun 8, 2026
eadc30c
38645
JoshuaKGoldberg Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion static/app/utils/analytics/replayAnalyticsEvents.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type {LayoutKey} from 'sentry/utils/replays/hooks/useReplayLayout';
import type {Output} from 'sentry/views/explore/replays/detail/network/details/getOutputType';
import type {Output} from 'sentry/views/explore/replays/detail/network/details/output';

export type ReplayEventParameters = {
'replay.ai-summary.chapter-clicked': {
Expand Down
11 changes: 7 additions & 4 deletions static/app/utils/replays/types.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ import type {
} from '@sentry/react';
import invariant from 'invariant';

import type {Event} from 'sentry/types/event';

export type {serializedNodeWithId} from '@sentry-internal/rrweb-snapshot';
export type {fullSnapshotEvent, incrementalSnapshotEvent} from '@sentry-internal/rrweb';

Expand Down Expand Up @@ -214,8 +212,13 @@ export function isFeedbackFrame(frame: ReplayFrame | undefined): frame is Feedba
return Boolean(frame && 'category' in frame && frame.category === 'feedback');
}

export function isHydrateCrumb(item: BreadcrumbFrame | Event): item is BreadcrumbFrame {
return 'category' in item && item.category === 'replay.hydrate-error';
export function isHydrateCrumb(item: unknown): item is BreadcrumbFrame {
return (
typeof item === 'object' &&
item !== null &&
'category' in item &&
item.category === 'replay.hydrate-error'
);
}

export function isSpanFrame(frame: ReplayFrame | undefined): frame is SpanFrame {
Expand Down
6 changes: 2 additions & 4 deletions static/app/views/explore/replays/detail/network/details/content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,12 @@ import {trackAnalytics} from 'sentry/utils/analytics';
import {getFrameMethod, getFrameStatus} from 'sentry/utils/replays/resourceFrame';
import {useOrganization} from 'sentry/utils/useOrganization';
import {FluidHeight} from 'sentry/views/explore/replays/detail/layout/fluidHeight';
import {
getOutputType,
Output,
} from 'sentry/views/explore/replays/detail/network/details/getOutputType';
import {getOutputType} from 'sentry/views/explore/replays/detail/network/details/getOutputType';
import {
Setup,
UnsupportedOp,
} from 'sentry/views/explore/replays/detail/network/details/onboarding';
import {Output} from 'sentry/views/explore/replays/detail/network/details/output';
import type {SectionProps} from 'sentry/views/explore/replays/detail/network/details/sections';
import {
GeneralSection,
Expand Down
12 changes: 1 addition & 11 deletions static/app/views/explore/replays/detail/network/details/getOutputType.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,8 @@
import {isRequestFrame} from 'sentry/utils/replays/resourceFrame';
import {Output} from 'sentry/views/explore/replays/detail/network/details/output';
import type {SectionProps} from 'sentry/views/explore/replays/detail/network/details/sections';
import type {TabKey} from 'sentry/views/explore/replays/detail/network/details/tabs';

export enum Output {
SETUP = 'setup',
UNSUPPORTED = 'unsupported',
URL_SKIPPED = 'url_skipped',
BODY_SKIPPED = 'body_skipped',
BODY_PARSE_ERROR = 'body_parse_error',
BODY_PARSE_TIMEOUT = 'body_parse_timeout',
UNPARSEABLE_BODY_TYPE = 'unparseable_body_type',
DATA = 'data',
}

type Args = {
isCaptureBodySetup: boolean;
isSetup: boolean;
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/explore/replays/detail/network/details/onboarding.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import {textWithMarkupMatcher} from 'sentry-test/utils';

import {hydrateSpans} from 'sentry/utils/replays/hydrateSpans';
import {useProjectSdkNeedsUpdate} from 'sentry/utils/useProjectSdkNeedsUpdate';
import {Output} from 'sentry/views/explore/replays/detail/network/details/getOutputType';
import {Setup} from 'sentry/views/explore/replays/detail/network/details/onboarding';
import {Output} from 'sentry/views/explore/replays/detail/network/details/output';

jest.mock('sentry/utils/useProjectSdkNeedsUpdate');

Expand Down
2 changes: 1 addition & 1 deletion static/app/views/explore/replays/detail/network/details/onboarding.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import type {SpanFrame} from 'sentry/utils/replays/types';
import {useDismissAlert} from 'sentry/utils/useDismissAlert';
import {useOrganization} from 'sentry/utils/useOrganization';
import {useProjectSdkNeedsUpdate} from 'sentry/utils/useProjectSdkNeedsUpdate';
import {Output} from 'sentry/views/explore/replays/detail/network/details/getOutputType';
import {Output} from 'sentry/views/explore/replays/detail/network/details/output';
import type {TabKey} from 'sentry/views/explore/replays/detail/network/details/tabs';

export const useDismissReqRespBodiesAlert = () => {
Expand Down
10 changes: 10 additions & 0 deletions static/app/views/explore/replays/detail/network/details/output.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
export enum Output {
SETUP = 'setup',
UNSUPPORTED = 'unsupported',
URL_SKIPPED = 'url_skipped',
BODY_SKIPPED = 'body_skipped',
BODY_PARSE_ERROR = 'body_parse_error',
BODY_PARSE_TIMEOUT = 'body_parse_timeout',
UNPARSEABLE_BODY_TYPE = 'unparseable_body_type',
DATA = 'data',
}
2 changes: 1 addition & 1 deletion static/app/views/insights/pages/mcp/onboarding.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ const BulletList = styled('ul')`
const HeaderWrapper = styled('div')`
display: flex;
justify-content: space-between;
gap: $${p => p.theme.space['2xl']};
gap: ${p => p.theme.space['2xl']};

@ryan953 ryan953 Jun 8, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kinda off topic tho

@JoshuaKGoldberg JoshuaKGoldberg Jun 8, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed. I'm surprised no linting thing caught this.

@JoshuaKGoldberg JoshuaKGoldberg Jun 8, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#117121

border-radius: ${p => p.theme.radius.md};
padding: ${p => p.theme.space['3xl']};
`;
Expand Down
Loading