ref(plugins): Inline PluginComponentBase into its two subclasses#116112
Draft
ryan953 wants to merge 1 commit into
Draft
ref(plugins): Inline PluginComponentBase into its two subclasses#116112ryan953 wants to merge 1 commit into
ryan953 wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
Scope: Frontend
![semgrep-code-getsentry[bot]](https://avatars.githubusercontent.com/in/1153895?s=60&v=4){kind=small}
| } | ||
|
|
||
| if (!isDemoModeActive()) { | ||
| Cookies.set('session_expired', '1'); |
Contributor
There was a problem hiding this comment.
Risk: Affected versions of js-cookie are vulnerable to Improperly Controlled Modification of Object Prototype Attributes ('Prototype Pollution'). The internal assign() helper in js-cookie walks attribute objects with a for..in loop and writes properties directly onto the target, which lets a __proto__ key from a JSON-parsed source trigger the Object.prototype.__proto__ setter. An attacker who controls any attributes object passed to set, remove, withAttributes, or withConverter can inject cookie attributes (domain, path, secure, samesite, expires) and pull off session fixation or downgrade Secure/SameSite protections.
Fix: Upgrade this library to at least version 3.0.7 at sentry/pnpm-lock.yaml:6510.
Reference(s): GHSA-qjx8-664m-686j
⭐ Removed in commit 8e42cbb ⭐
Contributor
📊 Type Coverage Diff
🔍 46 new type safety issues introduced
...and 25 more Type assertions (
This is informational only and does not block the PR. |
The abstract PluginComponentBase class was only extended by PluginSettings and IssueActions. Inline all base class logic (state management, save/load lifecycle, renderField, API client) directly into each consumer and delete the base class file. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ryan953
force-pushed
the
ref/inline-plugin-component-base
branch
from
4272db0 to
8e42cbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PluginComponentBaseclass directly into its only two consumers:PluginSettingsandIssueActionsComponentdirectly with all base class logic (state management, save/load lifecycle,renderField, API client) copied instatic/app/plugins/pluginComponentBase.tsxTest plan
pnpm run typecheck)pluginConfig.spec.tsx,pluginDetailedView.spec.tsx)