From fc7b4d8f55b975459a7ae9dec049f823301dff7d Mon Sep 17 00:00:00 2001 From: Dan Fuller Date: Mon, 18 May 2026 12:19:52 -0700 Subject: [PATCH 1/2] ref(repositories): Drop old project/repository columns Phase 2 of SafeRemoveField: actually drop the pending columns from RepositoryProjectPathConfig and SeerProjectRepository. Co-Authored-By: Claude Opus 4 --- migrations_lockfile.txt | 4 +-- .../migrations/1099_drop_old_fk_columns.py | 36 +++++++++++++++++++ .../migrations/0017_drop_old_fk_columns.py | 36 +++++++++++++++++++ 3 files changed, 74 insertions(+), 2 deletions(-) create mode 100644 src/sentry/migrations/1099_drop_old_fk_columns.py create mode 100644 src/sentry/seer/migrations/0017_drop_old_fk_columns.py diff --git a/migrations_lockfile.txt b/migrations_lockfile.txt index 357d2c4d0495..f9636cb0a278 100644 --- a/migrations_lockfile.txt +++ b/migrations_lockfile.txt @@ -29,9 +29,9 @@ releases: 0004_cleanup_failed_safe_deletes replays: 0007_organizationmember_replay_access -seer: 0016_remove_old_fks +seer: 0017_drop_old_fk_columns -sentry: 1098_remove_old_fks +sentry: 1099_drop_old_fk_columns social_auth: 0003_social_auth_json_field diff --git a/src/sentry/migrations/1099_drop_old_fk_columns.py b/src/sentry/migrations/1099_drop_old_fk_columns.py new file mode 100644 index 000000000000..b82d23b92a1a --- /dev/null +++ b/src/sentry/migrations/1099_drop_old_fk_columns.py @@ -0,0 +1,36 @@ +from sentry.new_migrations.migrations import CheckedMigration +from sentry.new_migrations.monkey.fields import SafeRemoveField +from sentry.new_migrations.monkey.state import DeletionAction + + +class Migration(CheckedMigration): + # This flag is used to mark that a migration shouldn't be automatically run in production. + # This should only be used for operations where it's safe to run the migration after your + # code has deployed. So this should not be used for most operations that alter the schema + # of a table. + # Here are some things that make sense to mark as post deployment: + # - Large data migrations. Typically we want these to be run manually so that they can be + # monitored and not block the deploy for a long period of time while they run. + # - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to + # run this outside deployments so that we don't block them. Note that while adding an index + # is a schema change, it's completely safe to run the operation after the code has deployed. + # Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment + + is_post_deployment = True + + dependencies = [ + ("sentry", "1098_remove_old_fks"), + ] + + operations = [ + SafeRemoveField( + model_name="repositoryprojectpathconfig", + name="project", + deletion_action=DeletionAction.DELETE, + ), + SafeRemoveField( + model_name="repositoryprojectpathconfig", + name="repository", + deletion_action=DeletionAction.DELETE, + ), + ] diff --git a/src/sentry/seer/migrations/0017_drop_old_fk_columns.py b/src/sentry/seer/migrations/0017_drop_old_fk_columns.py new file mode 100644 index 000000000000..20e1ed11f187 --- /dev/null +++ b/src/sentry/seer/migrations/0017_drop_old_fk_columns.py @@ -0,0 +1,36 @@ +from sentry.new_migrations.migrations import CheckedMigration +from sentry.new_migrations.monkey.fields import SafeRemoveField +from sentry.new_migrations.monkey.state import DeletionAction + + +class Migration(CheckedMigration): + # This flag is used to mark that a migration shouldn't be automatically run in production. + # This should only be used for operations where it's safe to run the migration after your + # code has deployed. So this should not be used for most operations that alter the schema + # of a table. + # Here are some things that make sense to mark as post deployment: + # - Large data migrations. Typically we want these to be run manually so that they can be + # monitored and not block the deploy for a long period of time while they run. + # - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to + # run this outside deployments so that we don't block them. Note that while adding an index + # is a schema change, it's completely safe to run the operation after the code has deployed. + # Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment + + is_post_deployment = True + + dependencies = [ + ("seer", "0016_remove_old_fks"), + ] + + operations = [ + SafeRemoveField( + model_name="seerprojectrepository", + name="project", + deletion_action=DeletionAction.DELETE, + ), + SafeRemoveField( + model_name="seerprojectrepository", + name="repository", + deletion_action=DeletionAction.DELETE, + ), + ] From 63c0197ad5a8e6057115b1ba544d535d8b297dcc Mon Sep 17 00:00:00 2001 From: Dan Fuller Date: Mon, 18 May 2026 12:53:10 -0700 Subject: [PATCH 2/2] fix: Set is_post_deployment = False for column drop migrations Schema changes are never post-deployment. Co-Authored-By: Claude Opus 4 --- src/sentry/migrations/1099_drop_old_fk_columns.py | 2 +- src/sentry/seer/migrations/0017_drop_old_fk_columns.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/sentry/migrations/1099_drop_old_fk_columns.py b/src/sentry/migrations/1099_drop_old_fk_columns.py index b82d23b92a1a..d1665036a085 100644 --- a/src/sentry/migrations/1099_drop_old_fk_columns.py +++ b/src/sentry/migrations/1099_drop_old_fk_columns.py @@ -16,7 +16,7 @@ class Migration(CheckedMigration): # is a schema change, it's completely safe to run the operation after the code has deployed. # Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment - is_post_deployment = True + is_post_deployment = False dependencies = [ ("sentry", "1098_remove_old_fks"), diff --git a/src/sentry/seer/migrations/0017_drop_old_fk_columns.py b/src/sentry/seer/migrations/0017_drop_old_fk_columns.py index 20e1ed11f187..79a5cfd7b100 100644 --- a/src/sentry/seer/migrations/0017_drop_old_fk_columns.py +++ b/src/sentry/seer/migrations/0017_drop_old_fk_columns.py @@ -16,7 +16,7 @@ class Migration(CheckedMigration): # is a schema change, it's completely safe to run the operation after the code has deployed. # Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment - is_post_deployment = True + is_post_deployment = False dependencies = [ ("seer", "0016_remove_old_fks"),