Skip to content

Conversation

@Dav1dde
Copy link
Member

@Dav1dde Dav1dde commented Nov 12, 2025

The field is no longer part of the Schema, Relay extracts it to an attribute already for Transaction and OTLP Spans.

Relay: getsentry/relay#5368
Schema: getsentry/sentry-kafka-schemas#457

No more usages of Span Kind:

┌─── [🐍.venv] src/sentry/spans <dav1d/rm-span-kind> 
└─ % rg kind
buffer.py
58:    * span-buf:z:* -- the actual set keys, containing span payloads. Each key contains all data for a segment. The most memory-intensive kind of key.

consumers/process_segments/enrichment.py
216:    Check the measurements on the span to determine what kind of start type the

Closes: INGEST-631

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 12, 2025
@Dav1dde Dav1dde requested a review from a team November 12, 2025 08:06
@Dav1dde Dav1dde marked this pull request as ready for review November 12, 2025 08:27
@Dav1dde Dav1dde requested review from a team as code owners November 12, 2025 08:27
@Dav1dde Dav1dde self-assigned this Nov 12, 2025
@Dav1dde Dav1dde added the Do Not Merge Don't merge label Nov 12, 2025
@Dav1dde
Copy link
Member Author

Dav1dde commented Nov 12, 2025

Ready for Review, but still depends on the Relay change.

@linear
Copy link

linear bot commented Nov 12, 2025

@Dav1dde Dav1dde merged commit 8309e51 into master Nov 13, 2025
72 checks passed
@Dav1dde Dav1dde deleted the dav1d/rm-span-kind branch November 13, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do Not Merge Don't merge Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants