Merge branch 'master' into scttcper/external-issue-tabs

Author: scttcper

.pre-commit-config.yaml

@@ -118,7 +118,7 @@ repos:
         # "Expected at least one target file" when its config drops every
         # input file, so skip them at the hook level instead.
         exclude: ^(api-docs|fixtures)/.*\.json$
-        entry: ./node_modules/.bin/oxfmt
+        entry: ./node_modules/.bin/oxfmt --no-error-on-unmatched-pattern
 
       - id: knip
         name: knip

pnpm-lock.yaml

@@ -3,7 +3,7 @@
 from datetime import datetime, timedelta
 from enum import Enum
 from math import floor
-from typing import TypedDict
+from typing import Any, TypedDict
 
 import sentry_sdk
 from django.db.models import Max
@@ -522,6 +522,25 @@ def _validate_text_widget(self, data):
 
         return data
 
+    def _validate_tracemetrics_equation_constraints(self, data) -> dict[str, Any]:
+        if not data.get("widget_type") == DashboardWidgetTypes.TRACEMETRICS:
+            return data
+
+        # Tracemetrics timeseries widgets only support a single equation per query
+        if data.get("display_type") in {
+            DashboardWidgetDisplayTypes.LINE_CHART,
+            DashboardWidgetDisplayTypes.AREA_CHART,
+            DashboardWidgetDisplayTypes.BAR_CHART,
+        }:
+            for query in data.get("queries"):
+                aggregates = query.get("aggregates") or []
+                if any(is_equation(aggregate) for aggregate in aggregates) and len(aggregates) > 1:
+                    raise serializers.ValidationError(
+                        {"queries": "Tracemetrics timeseries widgets support at most one equation."}
+                    )
+
+        return data
+
     def validate(self, data):
         self.query_warnings = {"queries": [], "columns": {}}
 
@@ -570,6 +589,9 @@ def validate(self, data):
             )
 
         if data.get("queries"):
+            if data.get("widget_type") == DashboardWidgetTypes.TRACEMETRICS:
+                self._validate_tracemetrics_equation_constraints(data)
+
             # Check each query to see if they have an issue or discover error depending on the type of the widget
             for query in data.get("queries"):
                 if len(query.get("columns", [])) > 0:

src/sentry/api/serializers/rest_framework/dashboard.py

@@ -0,0 +1,36 @@
+from __future__ import annotations
+
+from collections.abc import Mapping
+from typing import Any
+
+from sentry.lang.dart.utils import (
+    get_debug_meta_image_ids,
+    has_native_frames_in_stacktraces,
+)
+from sentry.lang.java.utils import has_proguard_file
+from sentry.plugins.base.v2 import EventPreprocessor
+
+
+def get_event_preprocessors(data: Mapping[str, Any]) -> list[EventPreprocessor]:
+    """Return all preprocessors needed for this event."""
+    from sentry.lang.dart.utils import deobfuscate_exception_type
+    from sentry.lang.java.processing import deobfuscate_exception_value
+    from sentry.lang.javascript.preprocessing import preprocess_event
+
+    preprocessors: list[EventPreprocessor] = []
+    if has_proguard_file(data):
+        preprocessors.append(deobfuscate_exception_value)
+    if data.get("platform") in ("javascript", "node"):
+        preprocessors.append(preprocess_event)
+    if _is_obfuscated_dart_event(data):
+        preprocessors.append(deobfuscate_exception_type)
+    return preprocessors
+
+
+def _is_obfuscated_dart_event(data: Mapping[str, Any]) -> bool:
+    sdk_name = (data.get("sdk") or {}).get("name", "")
+    if sdk_name not in ("sentry.dart", "sentry.dart.flutter"):
+        return False
+    if not get_debug_meta_image_ids(dict(data)):
+        return False
+    return has_native_frames_in_stacktraces(data)

src/sentry/event_preprocessors.py

@@ -86,6 +86,7 @@ def register_temporary_features(manager: FeatureManager) -> None:
     # Enable default anomaly detection metric monitor for new projects
     manager.add("organizations:default-anomaly-detector", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
     manager.add("organizations:derive-tags-without-plugins", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
+    manager.add("organizations:event-preprocessors-without-plugins", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
     # Enable the discover saved queries deprecation warnings
     manager.add("organizations:discover-saved-queries-deprecation", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
     # Enable migration of transaction widgets and queries to spans

src/sentry/features/temporary.py

@@ -8,6 +8,8 @@
 from sentry.stacktraces.processing import find_stacktraces_in_data
 
 
+# Deprecated: preprocessor logic moved to sentry.event_preprocessors.
+# TODO(christinarlong): Delete after organizations:event-preprocessors-without-plugins is fully rolled out.
 class DartPlugin(Plugin2):
     """
     This plugin is responsible for Dart specific processing on events or attachments.

src/sentry/lang/dart/plugin.py

@@ -10,6 +10,7 @@
 
 from sentry.models.debugfile import ProjectDebugFile
 from sentry.models.project import Project
+from sentry.stacktraces.processing import find_stacktraces_in_data
 from sentry.utils.safe import get_path
 
 # Obfuscated type values are either in the form of "xyz" or "xyz<abc>" where
@@ -109,3 +110,11 @@ def replace_symbol(match: re.Match[str]) -> str:
                 new_value = re.sub(INSTANCE_OF_VALUE_RE, replace_symbol, exception_value)
                 if new_value != exception_value:
                     exception["value"] = new_value
+
+
+def has_native_frames_in_stacktraces(data) -> bool:
+    for stacktrace_info in find_stacktraces_in_data(data):
+        frames = stacktrace_info.get_frames()
+        if frames and any(frame.get("platform") == "native" for frame in frames):
+            return True
+    return False

src/sentry/lang/dart/utils.py

@@ -8,6 +8,8 @@
 from sentry.plugins.base.v2 import EventPreprocessor, Plugin2
 
 
+# Deprecated: preprocessor logic moved to sentry.event_preprocessors.
+# TODO(christinarlong): Delete after organizations:event-preprocessors-without-plugins is fully rolled out.
 class JavaPlugin(Plugin2):
     can_disable = False
 

src/sentry/lang/java/plugin.py

@@ -33,6 +33,8 @@ def generate_modules(data):
                 frame["module"] = generate_module(abs_path)
 
 
+# Deprecated: preprocessor logic moved to sentry.event_preprocessors and sentry.lang.javascript.preprocessing.
+# TODO(christinarlong): Delete after organizations:event-preprocessors-without-plugins is fully rolled out.
 class JavascriptPlugin(Plugin2):
     can_disable = False
 

src/sentry/lang/javascript/plugin.py

@@ -0,0 +1,26 @@
+from __future__ import annotations
+
+from sentry.stacktraces.processing import find_stacktraces_in_data
+from sentry.utils.safe import get_path
+
+from .errorlocale import translate_exception
+from .errormapping import rewrite_exception
+from .utils import generate_module
+
+
+def preprocess_event(data):
+    rewrite_exception(data)
+    translate_exception(data)
+    generate_modules(data)
+    return data
+
+
+def generate_modules(data):
+    for info in find_stacktraces_in_data(data):
+        for frame in get_path(info.stacktrace, "frames", filter=True, default=()):
+            platform = frame.get("platform") or data["platform"]
+            if platform not in ("javascript", "node") or frame.get("module"):
+                continue
+            abs_path = frame.get("abs_path")
+            if abs_path and abs_path.startswith(("http:", "https:", "webpack:", "app:")):
+                frame["module"] = generate_module(abs_path)