ref(onboarding): Report project-details completion through one callback

The project-details hook fired onProjectCreated,
onProjectDetailsFormChange, and onComplete in sequence at the end of a
successful submit, an artifact of extracting the inline step logic. The
single-view project-creation host needs the created project (id and
slug) and the submitted form at the same moment to snapshot its wizard
session and navigate, so replace the three callbacks with one onComplete
carrying both, and widen the payload from the project slug to the
project itself.

The onboarding step forwards the same values to its existing context
setters, so its behavior is unchanged. The reuse path now reports the
reused project and form state, which match what the host already has
stored.

Author: jaydgoss

static/app/views/onboarding/components/useScmProjectDetails.ts

@@ -8,6 +8,7 @@ import {t} from 'sentry/locale';
 import type {Repository} from 'sentry/types/integrations';
 import type {OnboardingSelectedSDK} from 'sentry/types/onboarding';
 import type {Team} from 'sentry/types/organization';
+import type {Project} from 'sentry/types/project';
 import {trackAnalytics} from 'sentry/utils/analytics';
 import {fetchMutation} from 'sentry/utils/queryClient';
 import type {RequestError} from 'sentry/utils/requestError/requestError';
@@ -52,12 +53,22 @@ const CREATE_FAILED_EVENT = {
   'project-creation': 'project_creation.scm_project_details_create_failed',
 } as const;
 
+export interface ScmProjectDetailsCompletion {
+  /** The created project, or the reused one on the unchanged back-nav path. */
+  project: Project;
+  /** The form state the project was created with. */
+  projectDetailsForm: ProjectDetailsFormState;
+}
+
 interface UseScmProjectDetailsOptions {
   analyticsFlow: ScmAnalyticsFlow;
-  /** Called after a project is created (or an unchanged one reused). */
-  onComplete: () => void;
-  onProjectCreated: (slug: string | undefined) => void;
-  onProjectDetailsFormChange: (form: ProjectDetailsFormState) => void;
+  /**
+   * Called once the step is done: a project was created (or an unchanged one
+   * reused on the back-nav path) and the repo link attempted. Receives the
+   * project and the submitted form state together so the host can persist
+   * both and advance in one place.
+   */
+  onComplete: (completion: ScmProjectDetailsCompletion) => void;
   selectedPlatform: OnboardingSelectedSDK | undefined;
   selectedRepository: Repository | undefined;
   /**
@@ -106,8 +117,6 @@ interface ScmProjectDetailsForm {
 export function useScmProjectDetails({
   analyticsFlow,
   onComplete,
-  onProjectCreated,
-  onProjectDetailsFormChange,
   selectedPlatform,
   selectedRepository,
   createdProjectSlug,
@@ -216,6 +225,12 @@ export function useScmProjectDetails({
 
     trackAnalytics(CREATE_CLICKED_EVENT[analyticsFlow], {organization});
 
+    const submittedForm = {
+      projectName: projectNameResolved,
+      teamSlug: teamSlugResolved,
+      alertRuleConfig,
+    };
+
     // User navigated back and clicked Create without changing anything; skip
     // to completion without creating a duplicate. Any actual change abandons
     // the previous project and creates a new one, matching legacy onboarding.
@@ -224,7 +239,7 @@ export function useScmProjectDetails({
         organization,
         project_slug: existingProject.slug,
       });
-      onComplete();
+      onComplete({project: existingProject, projectDetailsForm: submittedForm});
       return;
     }
 
@@ -237,10 +252,6 @@ export function useScmProjectDetails({
         createNotificationAction: () => {},
       });
 
-      // Store the project slug separately so the host can find the project
-      // without corrupting selectedPlatform.key.
-      onProjectCreated(project.slug);
-
       if (selectedRepository?.id) {
         try {
           await fetchMutation({
@@ -253,18 +264,12 @@ export function useScmProjectDetails({
         }
       }
 
-      onProjectDetailsFormChange({
-        projectName: projectNameResolved,
-        teamSlug: teamSlugResolved,
-        alertRuleConfig,
-      });
-
       trackAnalytics(CREATE_SUCCEEDED_EVENT[analyticsFlow], {
         organization,
         project_slug: project.slug,
       });
 
-      onComplete();
+      onComplete({project, projectDetailsForm: submittedForm});
     } catch (error) {
       trackAnalytics(CREATE_FAILED_EVENT[analyticsFlow], {organization});
       addErrorMessage(t('Failed to create project'));
@@ -279,8 +284,6 @@ export function useScmProjectDetails({
     isOrgMemberWithNoAccess,
     nothingChanged,
     onComplete,
-    onProjectCreated,
-    onProjectDetailsFormChange,
     organization,
     projectNameResolved,
     selectedPlatform,

static/app/views/onboarding/scmProjectDetails.tsx

@@ -44,10 +44,15 @@ export function ScmProjectDetails({
     selectedRepository,
     createdProjectSlug,
     projectDetailsForm,
-    onProjectCreated,
-    onProjectDetailsFormChange,
-    onComplete: () =>
-      onComplete(undefined, selectedFeatures ? {product: selectedFeatures} : undefined),
+    onComplete: ({project, projectDetailsForm: submittedForm}) => {
+      // Store the slug separately so onboarding.tsx can find the project via
+      // useRecentCreatedProject without corrupting selectedPlatform.key (which
+      // the platform features step needs), and persist the form so navigating
+      // back from setup-docs restores it. Both land before the step advances.
+      onProjectCreated(project.slug);
+      onProjectDetailsFormChange(submittedForm);
+      onComplete(undefined, selectedFeatures ? {product: selectedFeatures} : undefined);
+    },
   });
 
   return (