Skip to content

Commit bf8aa97

Browse files
ref(search): Drop filter_value from multi-select analytics
Per review, do not log the actual filter value in the search.multi_value_selected event. Keep only the number of selections. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 7332981 commit bf8aa97

3 files changed

Lines changed: 0 additions & 4 deletions

File tree

static/app/components/searchQueryBuilder/index.spec.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3313,7 +3313,6 @@ describe('SearchQueryBuilder', () => {
33133313
expect.objectContaining({
33143314
search_source: 'ourlogs',
33153315
filter_key: 'browser.name',
3316-
filter_value: 'Chrome',
33173316
selected: true,
33183317
selected_count: 2,
33193318
})
@@ -3343,7 +3342,6 @@ describe('SearchQueryBuilder', () => {
33433342
expect.objectContaining({
33443343
search_source: 'ourlogs',
33453344
filter_key: 'browser.name',
3346-
filter_value: 'Chrome',
33473345
selected: false,
33483346
selected_count: 1,
33493347
})

static/app/components/searchQueryBuilder/tokens/filter/valueCombobox.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -608,7 +608,6 @@ function ItemCheckbox({
608608

609609
trackAnalytics('search.multi_value_selected', {
610610
...analyticsData,
611-
filter_value: value,
612611
selected: !currentlySelected,
613612
selected_count: currentlySelected ? selectedCount - 1 : selectedCount + 1,
614613
});

static/app/utils/analytics/searchAnalyticsEvents.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ export type SearchEventParameters = {
6060
'search.multi_value_selected': Omit<SearchEventBase, 'query'> & {
6161
filter_key: string;
6262
filter_operator: string;
63-
filter_value: string;
6463
filter_value_type: string;
6564
selected: boolean;
6665
selected_count: number;

0 commit comments

Comments
 (0)