Skip to content

Commit be0f4da

Browse files
feat(insights): Removes unused webvitals function query and code (#82485)
The frontend doesn't actually use the `weighted_performance_score` function anymore. Removes all calls and references from frontend code.
1 parent 16d4d44 commit be0f4da

File tree

5 files changed

+19
-66
lines changed

5 files changed

+19
-66
lines changed

static/app/views/insights/browser/webVitals/components/charts/performanceScoreBreakdownChart.spec.tsx

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,6 @@ describe('PerformanceScoreBreakdownChart', function () {
7272
method: 'GET',
7373
query: expect.objectContaining({
7474
yAxis: [
75-
'weighted_performance_score(measurements.score.lcp)',
76-
'weighted_performance_score(measurements.score.fcp)',
77-
'weighted_performance_score(measurements.score.cls)',
78-
'weighted_performance_score(measurements.score.inp)',
79-
'weighted_performance_score(measurements.score.ttfb)',
8075
'performance_score(measurements.score.lcp)',
8176
'performance_score(measurements.score.fcp)',
8277
'performance_score(measurements.score.cls)',

static/app/views/insights/browser/webVitals/components/charts/performanceScoreBreakdownChart.tsx

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -72,13 +72,13 @@ export function PerformanceScoreBreakdownChart({
7272
chartSeriesOrder
7373
);
7474

75-
const unweightedTimeseries = formatTimeSeriesResultsToChartData(
75+
const timeseries = formatTimeSeriesResultsToChartData(
7676
{
77-
lcp: timeseriesData.unweightedLcp,
78-
fcp: timeseriesData.unweightedFcp,
79-
cls: timeseriesData.unweightedCls,
80-
ttfb: timeseriesData.unweightedTtfb,
81-
inp: timeseriesData.unweightedInp,
77+
lcp: timeseriesData.lcp,
78+
fcp: timeseriesData.fcp,
79+
cls: timeseriesData.cls,
80+
ttfb: timeseriesData.ttfb,
81+
inp: timeseriesData.inp,
8282
total: timeseriesData.total,
8383
},
8484
segmentColors,
@@ -128,10 +128,10 @@ export function PerformanceScoreBreakdownChart({
128128
},
129129
valueFormatter: (_value, _label, seriesParams: any) => {
130130
const timestamp = seriesParams?.data[0];
131-
const unweightedValue = unweightedTimeseries
131+
const value = timeseries
132132
.find(series => series.seriesName === seriesParams?.seriesName)
133133
?.data.find(dataPoint => dataPoint.name === timestamp)?.value;
134-
return `<span class="tooltip-label-value">${unweightedValue}</span>`;
134+
return `<span class="tooltip-label-value">${value}</span>`;
135135
},
136136
}}
137137
/>

static/app/views/insights/browser/webVitals/queries/storedScoreQueries/useProjectWebVitalsScoresTimeseriesQuery.tsx

Lines changed: 2 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,6 @@ export type WebVitalsScoreBreakdown = {
3232
ttfb: SeriesDataUnit[];
3333
};
3434

35-
export type UnweightedWebVitalsScoreBreakdown = {
36-
unweightedCls: SeriesDataUnit[];
37-
unweightedFcp: SeriesDataUnit[];
38-
unweightedInp: SeriesDataUnit[];
39-
unweightedLcp: SeriesDataUnit[];
40-
unweightedTtfb: SeriesDataUnit[];
41-
};
42-
4335
export const useProjectWebVitalsScoresTimeseriesQuery = ({
4436
transaction,
4537
tag,
@@ -66,11 +58,6 @@ export const useProjectWebVitalsScoresTimeseriesQuery = ({
6658
const projectTimeSeriesEventView = EventView.fromNewQueryWithPageFilters(
6759
{
6860
yAxis: [
69-
'weighted_performance_score(measurements.score.lcp)',
70-
'weighted_performance_score(measurements.score.fcp)',
71-
'weighted_performance_score(measurements.score.cls)',
72-
'weighted_performance_score(measurements.score.inp)',
73-
'weighted_performance_score(measurements.score.ttfb)',
7461
'performance_score(measurements.score.lcp)',
7562
'performance_score(measurements.score.fcp)',
7663
'performance_score(measurements.score.cls)',
@@ -115,36 +102,19 @@ export const useProjectWebVitalsScoresTimeseriesQuery = ({
115102
referrer: 'api.performance.browser.web-vitals.timeseries-scores',
116103
});
117104

118-
const data: WebVitalsScoreBreakdown & UnweightedWebVitalsScoreBreakdown = {
105+
const data: WebVitalsScoreBreakdown = {
119106
lcp: [],
120107
fcp: [],
121108
cls: [],
122109
ttfb: [],
123110
inp: [],
124111
total: [],
125-
unweightedCls: [],
126-
unweightedFcp: [],
127-
unweightedInp: [],
128-
unweightedLcp: [],
129-
unweightedTtfb: [],
130112
};
131113

132-
result?.data?.['weighted_performance_score(measurements.score.lcp)']?.data.forEach(
114+
result?.data?.['performance_score(measurements.score.lcp)']?.data.forEach(
133115
(interval, index) => {
134-
// Weighted data
135116
['lcp', 'fcp', 'cls', 'ttfb', 'inp'].forEach(webVital => {
136117
data[webVital].push({
137-
value:
138-
result?.data?.[`weighted_performance_score(measurements.score.${webVital})`]
139-
?.data[index][1][0].count * 100,
140-
name: interval[0] * 1000,
141-
});
142-
});
143-
// Unweighted data
144-
['lcp', 'fcp', 'cls', 'ttfb', 'inp'].forEach(webVital => {
145-
// Capitalize first letter of webVital
146-
const capitalizedWebVital = webVital.charAt(0).toUpperCase() + webVital.slice(1);
147-
data[`unweighted${capitalizedWebVital}`].push({
148118
value:
149119
result?.data?.[`performance_score(measurements.score.${webVital})`]?.data[
150120
index

static/app/views/insights/browser/webVitals/utils/applyStaticWeightsToTimeseries.spec.tsx

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,28 +3,23 @@ import {applyStaticWeightsToTimeseries} from 'sentry/views/insights/browser/webV
33
describe('applyStaticWeightsToTimeseries', function () {
44
it('updates timeseries scores with static weighing', function () {
55
const timeseriesData = {
6-
lcp: [],
7-
fcp: [],
8-
cls: [],
9-
ttfb: [],
10-
inp: [],
11-
unweightedLcp: [
6+
lcp: [
127
{name: '2024-07-01T00:00:00.000Z', value: 90},
138
{name: '2024-07-02T00:00:00.000Z', value: 40},
149
],
15-
unweightedFcp: [
10+
fcp: [
1611
{name: '2024-07-01T00:00:00.000Z', value: 30},
1712
{name: '2024-07-02T00:00:00.000Z', value: 20},
1813
],
19-
unweightedCls: [
14+
cls: [
2015
{name: '2024-07-01T00:00:00.000Z', value: 10},
2116
{name: '2024-07-02T00:00:00.000Z', value: 90},
2217
],
23-
unweightedTtfb: [
18+
ttfb: [
2419
{name: '2024-07-01T00:00:00.000Z', value: 22},
2520
{name: '2024-07-02T00:00:00.000Z', value: 43},
2621
],
27-
unweightedInp: [
22+
inp: [
2823
{name: '2024-07-01T00:00:00.000Z', value: 100},
2924
{name: '2024-07-02T00:00:00.000Z', value: 0},
3025
],
Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,16 @@
1-
import type {
2-
UnweightedWebVitalsScoreBreakdown,
3-
WebVitalsScoreBreakdown,
4-
} from 'sentry/views/insights/browser/webVitals/queries/storedScoreQueries/useProjectWebVitalsScoresTimeseriesQuery';
1+
import type {WebVitalsScoreBreakdown} from 'sentry/views/insights/browser/webVitals/queries/storedScoreQueries/useProjectWebVitalsScoresTimeseriesQuery';
52
import {PERFORMANCE_SCORE_WEIGHTS} from 'sentry/views/insights/browser/webVitals/utils/scoreThresholds';
63

74
// Returns a weighed score timeseries with each interval calculated from applying hardcoded weights to unweighted scores
8-
export function applyStaticWeightsToTimeseries(
9-
timeseriesData: WebVitalsScoreBreakdown & UnweightedWebVitalsScoreBreakdown
10-
) {
5+
export function applyStaticWeightsToTimeseries(timeseriesData: WebVitalsScoreBreakdown) {
116
return {
127
...Object.keys(PERFORMANCE_SCORE_WEIGHTS).reduce((acc, webVital) => {
13-
acc[webVital] = timeseriesData[
14-
`unweighted${webVital.charAt(0).toUpperCase()}${webVital.slice(1)}`
15-
].map(({name, value}) => ({
8+
acc[webVital] = timeseriesData[webVital].map(({name, value}) => ({
169
name,
1710
value: value * PERFORMANCE_SCORE_WEIGHTS[webVital] * 0.01,
1811
}));
1912
return acc;
2013
}, {}),
2114
total: timeseriesData.total,
22-
} as WebVitalsScoreBreakdown & UnweightedWebVitalsScoreBreakdown;
15+
} as WebVitalsScoreBreakdown;
2316
}

0 commit comments

Comments
 (0)