ref(seer): Drop state-push plumbing; link path just fetches

Avoiding the completion-hook re-query isn't worth a base-class change across
the hooks — the extra fetch is negligible relative to existing state-endpoint
traffic. The link path fetches run status directly.

Co-Authored-By: Claude <noreply@anthropic.com>

Author: trevor-e

src/sentry/seer/agent/on_completion_hook.py

@@ -8,7 +8,6 @@
 
 from sentry import options
 from sentry.models.organization import Organization
-from sentry.seer.agent.client_models import SeerRunState
 from sentry.seer.agent.client_utils import fetch_run_status
 from sentry.seer.pr_links import link_seer_run_to_pull_request
 
@@ -81,7 +80,6 @@ def call_on_completion_hook(
     module_path: str,
     organization_id: int,
     run_id: int,
-    state: dict | None = None,
     allowed_prefixes: tuple[str, ...] = ("sentry.",),
 ) -> None:
     """Dynamically import and call an on-completion hook class.
@@ -90,8 +88,6 @@ def call_on_completion_hook(
         module_path: Full module path to the hook class (e.g., "sentry.api.MyHook")
         organization_id: Organization ID to load and pass to the hook
         run_id: The run ID that completed
-        state: The completed run's serialized state, if Seer pushed it; lets us
-            skip re-querying Seer for PR linking.
         allowed_prefixes: Tuple of allowed module path prefixes for security
     """
     # Only allow imports from approved package prefixes
@@ -106,7 +102,7 @@ def call_on_completion_hook(
     except Organization.DoesNotExist:
         raise ValueError(f"Organization with id {organization_id} does not exist")
 
-    _link_run_pull_requests(organization, run_id, state)
+    _link_run_pull_requests(organization, run_id)
 
     # Split module path and class name
     parts = module_path.rsplit(".", 1)
@@ -130,19 +126,13 @@ def call_on_completion_hook(
     hook_class.execute(organization, run_id)
 
 
-def _link_run_pull_requests(
-    organization: Organization, run_id: int, state: dict | None
-) -> None:
-    """Record a SeerRunPullRequest for each PR the completed run opened.
-
-    Uses the run state Seer pushed with the hook call; falls back to querying Seer
-    when it wasn't provided.
-    """
+def _link_run_pull_requests(organization: Organization, run_id: int) -> None:
+    """Record a SeerRunPullRequest for each PR the completed run opened."""
     if options.get("seer.run-pr-link.killswitch.enabled"):
         return
 
     try:
-        run_state = SeerRunState(**state) if state is not None else fetch_run_status(run_id, organization)
+        run_state = fetch_run_status(run_id, organization)
     except Exception:
         logger.exception(
             "seer.pr_link.state_unavailable",

tests/sentry/seer/agent/test_on_completion_hook.py

@@ -99,25 +99,6 @@ def test_links_pull_requests_for_any_hook(self, mock_fetch) -> None:
         assert link.seer_run_id == run.id
         assert self.organization.get_option("test_hook_run_id") == 777
 
-    @patch("sentry.seer.agent.on_completion_hook.fetch_run_status")
-    def test_links_from_pushed_state_without_querying_seer(self, mock_fetch) -> None:
-        repo = self.create_repo(
-            self.project, name="getsentry/sentry", provider="integrations:github"
-        )
-        run = self.create_seer_run(organization=self.organization, seer_run_state_id=777)
-
-        call_on_completion_hook(
-            module_path=HOOK_PATH,
-            organization_id=self.organization.id,
-            run_id=777,
-            state=_state_with_pr(777, "getsentry/sentry", 5).dict(),
-            allowed_prefixes=("tests.sentry.",),
-        )
-
-        mock_fetch.assert_not_called()
-        pr = PullRequest.objects.get(repository_id=repo.id, key="5")
-        assert SeerRunPullRequest.objects.get(pull_request=pr).seer_run_id == run.id
-
     @patch("sentry.seer.agent.on_completion_hook.fetch_run_status")
     def test_killswitch_skips_linking_but_runs_hook(self, mock_fetch) -> None:
         self.create_repo(self.project, name="getsentry/sentry", provider="integrations:github")