Skip to content

Commit a683563

Browse files
committed
ref(integrations): Remove the unused setupDialog from the integration type
The integration setup popup that consumed `provider.setupDialog` (window URL/dimensions) was removed when integrations moved to the API-driven pipeline modal, and the backend no longer serializes the field. Drop the `setupDialog` type, along with the fixtures, stories, and spec that set it. Part of [VDY-32](https://linear.app/getsentry/issue/VDY-32/migrate-integration-setup-pipelines-to-api-driven-flows).
1 parent d1773a3 commit a683563

11 files changed

Lines changed: 0 additions & 39 deletions

static/app/types/integrations.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -383,7 +383,6 @@ export interface IntegrationProvider extends BaseIntegrationProvider {
383383
noun: string;
384384
source_url: string;
385385
};
386-
setupDialog: {height: number; url: string; width: number};
387386
}
388387

389388
interface OrganizationIntegrationProvider extends BaseIntegrationProvider {

static/app/views/settings/organizationIntegrations/integrationDetailedView.spec.tsx

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,6 @@ describe('IntegrationDetailedView', () => {
5151
},
5252
name: 'Bitbucket',
5353

54-
setupDialog: {
55-
height: 600,
56-
url: '/organizations/sentry/integrations/bitbucket/setup/',
57-
width: 600,
58-
},
5954
slug: 'bitbucket',
6055
},
6156
],

static/app/views/settings/organizationRepositories/components/connectProviderDropdown.stories.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ function makeProvider(key: string, name: string): IntegrationProvider {
1111
canAdd: true,
1212
canDisable: false,
1313
features: [],
14-
setupDialog: {url: '', width: 600, height: 600},
1514
metadata: {
1615
description: '',
1716
features: [],

static/app/views/settings/organizationRepositories/components/noIntegrationsEmptyState.stories.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ function makeProvider(key: string, name: string): IntegrationProvider {
1111
canAdd: true,
1212
canDisable: false,
1313
features: [],
14-
setupDialog: {url: '', width: 600, height: 600},
1514
metadata: {
1615
description: '',
1716
features: [],

static/app/views/settings/organizationRepositories/components/scmRepositoryTable.stories.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ const GITHUB_PROVIDER: IntegrationProvider = {
2323
canAdd: true,
2424
canDisable: false,
2525
features: [],
26-
setupDialog: {url: '', width: 600, height: 600},
2726
metadata: {
2827
description: '',
2928
features: [],

tests/js/fixtures/githubIntegrationProvider.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,6 @@ export function GitHubIntegrationProviderFixture(
99
name: 'GitHub',
1010
canAdd: true,
1111
features: [],
12-
setupDialog: {
13-
url: '/github-integration-setup-uri/',
14-
width: 100,
15-
height: 100,
16-
},
1712
canDisable: true,
1813
metadata: {
1914
description: '*markdown* formatted _description_',

tests/js/fixtures/gitlabIntegrationProvider.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,6 @@ export function GitLabIntegrationProviderFixture(
99
name: 'GitLab',
1010
canAdd: true,
1111
features: [],
12-
setupDialog: {
13-
url: '/gitlab-integration-setup-uri/',
14-
width: 100,
15-
height: 100,
16-
},
1712
canDisable: true,
1813
metadata: {
1914
description: '*markdown* formatted _description_',

tests/js/fixtures/integrationListDirectory.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,6 @@ export function ProviderListFixture(): {providers: IntegrationProvider[]} {
2929
},
3030
name: 'Bitbucket',
3131

32-
setupDialog: {
33-
height: 600,
34-
url: '/organizations/sentry/integrations/bitbucket/setup/',
35-
width: 600,
36-
},
3732
slug: 'bitbucket',
3833
},
3934
],

tests/js/fixtures/integrationProvider.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,6 @@ export function IntegrationProviderFixture(
99
name: 'Generic Provider',
1010
canAdd: true,
1111
features: [],
12-
setupDialog: {
13-
url: '/generic-provider-setup-uri/',
14-
width: 100,
15-
height: 100,
16-
},
1712
canDisable: true,
1813
metadata: {
1914
description: 'A generic integration provider for testing',

tests/js/fixtures/opsgenieIntegrationProvider.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,6 @@ export function OpsgenieIntegrationProviderFixture(
2323
canAdd: true,
2424
canDisable: false,
2525
features: ['alert-rule', 'incident-management'],
26-
setupDialog: {
27-
url: '/organizations/sentry/integrations/opsgenie/setup/',
28-
width: 600,
29-
height: 600,
30-
},
3126
...params,
3227
};
3328
}

0 commit comments

Comments
 (0)