ref: Remove organizations:event-preprocessors-without-plugins feature flag

The flag gating direct event preprocessing (bypassing plugin infra for
Java/JavaScript/Dart) is fully rolled out. Remove the flag and keep only
the new code path that calls get_event_preprocessors() directly.

- Remove flag check branching in should_process() and do_process_event()
- Delete deprecated JavaPlugin, JavascriptPlugin, DartPlugin classes
- Remove lang app configs from INSTALLED_APPS (no models/migrations)
- Delete associated plugin test files (logic covered by test_event_preprocessors.py)
- Update plugin registry test and JS test import

Author: Christinarlong

pyproject.toml

@@ -1023,9 +1023,7 @@ module = [
     "sentry.lang",
     "sentry.lang.dart.*",
     "sentry.lang.java",
-    "sentry.lang.java.apps",
     "sentry.lang.java.exceptions",
-    "sentry.lang.java.plugin",
     "sentry.lang.java.proguard",
     "sentry.lang.java.utils",
     "sentry.lang.java.view_hierarchies",

src/sentry/conf/server.py

@@ -482,9 +482,6 @@ def env(
     "sentry.sentry_metrics",
     "sentry.sentry_metrics.indexer.postgres.apps.Config",
     "sentry.snuba",
-    "sentry.lang.java.apps.Config",
-    "sentry.lang.javascript.apps.Config",
-    "sentry.lang.dart.apps.Config",
     "sentry.plugins.sentry_interface_types.apps.Config",
     "sentry.plugins.sentry_urls.apps.Config",
     "sentry.plugins.sentry_useragents.apps.Config",

src/sentry/features/temporary.py

@@ -85,8 +85,6 @@ def register_temporary_features(manager: FeatureManager) -> None:
     manager.add("organizations:intercom-support", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
     # Enable default anomaly detection metric monitor for new projects
     manager.add("organizations:default-anomaly-detector", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
-    # Don't use plugin infra for language plugins/preprocessor logic
-    manager.add("organizations:event-preprocessors-without-plugins", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
     # Enable the discover saved queries deprecation warnings
     manager.add("organizations:discover-saved-queries-deprecation", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
     # Enable migration of transaction widgets and queries to spans

src/sentry/lang/dart/apps.py

@@ -10,7 +10,7 @@
 import sentry_sdk
 from sentry_relay.processing import StoreNormalizer
 
-from sentry import features, options, reprocessing2
+from sentry import options, reprocessing2
 from sentry.attachments import delete_cached_and_ratelimited_attachments, get_attachments_for_event
 from sentry.constants import DEFAULT_STORE_NORMALIZER_ARGS
 from sentry.event_preprocessors import get_event_preprocessors
@@ -47,34 +47,19 @@ class RetryProcessing(Exception):
     pass
 
 
-LANGUAGE_PLUGIN_SLUGS = frozenset({"javaplugin", "javascriptplugin", "dartplugin"})
-
-
 def should_process(data: Mapping[str, Any]) -> bool:
     """Quick check if processing is needed at all."""
     from sentry.plugins.base import plugins
 
     if data.get("type") == "transaction":
         return False
 
-    project = Project.objects.get_from_cache(id=data["project"])
-    project.set_cached_field_value(
-        "organization", Organization.objects.get_from_cache(id=project.organization_id)
-    )
-    if features.has("organizations:event-preprocessors-without-plugins", project.organization):
-        if get_event_preprocessors(data):
+    if get_event_preprocessors(data):
+        return True
+    for plugin in plugins.all(version=2):
+        processors = safe_execute(plugin.get_event_preprocessors, data=data)
+        if processors:
             return True
-        for plugin in plugins.all(version=2):
-            if plugin.slug in LANGUAGE_PLUGIN_SLUGS:
-                continue
-            processors = safe_execute(plugin.get_event_preprocessors, data=data)
-            if processors:
-                return True
-    else:
-        for plugin in plugins.all(version=2):
-            processors = safe_execute(plugin.get_event_preprocessors, data=data)
-            if processors:
-                return True
 
     if should_process_for_stacktraces(data):
         return True
@@ -422,38 +407,17 @@ def _continue_to_save_event() -> None:
             data = new_data
 
     # Default event processors.
-    use_new_preprocessors = features.has(
-        "organizations:event-preprocessors-without-plugins", project.organization
-    )
-    if use_new_preprocessors:
-        preprocessors = get_event_preprocessors(data)
-        for plugin in plugins.all(version=2):
-            if plugin.slug in LANGUAGE_PLUGIN_SLUGS:
-                continue
-            preprocessors.extend(safe_execute(plugin.get_event_preprocessors, data=data) or ())
-    else:
-        preprocessors = []
-        for plugin in plugins.all(version=2):
-            preprocessors.extend(safe_execute(plugin.get_event_preprocessors, data=data) or ())
-
-    preprocessor_span_op = (
-        "task.store.process_event.new_preprocessors"
-        if use_new_preprocessors
-        else "task.store.process_event.preprocessors"
-    )
-    preprocessor_log_msg = (
-        "tasks.store.new_preprocessors.error"
-        if use_new_preprocessors
-        else "tasks.store.preprocessors.error"
-    )
+    preprocessors = get_event_preprocessors(data)
+    for plugin in plugins.all(version=2):
+        preprocessors.extend(safe_execute(plugin.get_event_preprocessors, data=data) or ())
 
-    with sentry_sdk.start_span(op=preprocessor_span_op) as span:
+    with sentry_sdk.start_span(op="task.store.process_event.preprocessors") as span:
         span.set_data("from_symbolicate", from_symbolicate)
         for processor in preprocessors:
             try:
                 result = processor(data)
             except Exception:
-                error_logger.exception(preprocessor_log_msg)
+                error_logger.exception("tasks.store.preprocessors.error")
                 data.setdefault("_metrics", {})["flag.processing.error"] = True
                 has_changed = True
             else: