fix(onboarding): Drop an unresolved repo from the wizard snapshot

An optimistic repository (empty id, see useScmRepoSelection) can be in
wizard state at completion when the user creates the project before the
repo resolution lands. Persisting it strands the restored session's
platform detection in a permanent pending state, since the query can
only fetch with a real id. Snapshot the session without it; the
committed platform and features still restore.

Author: jaydgoss

static/app/views/projectInstall/scmCreateProject.tsx

@@ -197,6 +197,12 @@ function ScmCreateProjectWizard({initialState}: {initialState: WizardState}) {
     ({project, projectDetailsForm: submittedForm}: ScmProjectDetailsCompletion) => {
       writeStorageValue(WIZARD_STORAGE_KEY, {
         ...wizardState,
+        // An optimistic repo (empty id, see useScmRepoSelection) can never
+        // fetch detection; restoring one would strand the platform section in
+        // a permanent spinner, so it is not worth persisting.
+        selectedRepository: wizardState.selectedRepository?.id
+          ? wizardState.selectedRepository
+          : undefined,
         createdProjectId: project.id,
         createdProjectSlug: project.slug,
         projectDetailsForm: submittedForm,