Skip to content

Commit 8309e51

Browse files
authored
ref(spans): Remove span kind from field extraction in consumer (#103209)
The field is no longer part of the Schema, Relay extracts it to an attribute already for Transaction and OTLP Spans. Relay: getsentry/relay#5368 Schema: getsentry/sentry-kafka-schemas#457 No more usages of Span Kind: ``` ┌─── [🐍.venv] src/sentry/spans <dav1d/rm-span-kind> └─ % rg kind buffer.py 58: * span-buf:z:* -- the actual set keys, containing span payloads. Each key contains all data for a segment. The most memory-intensive kind of key. consumers/process_segments/enrichment.py 216: Check the measurements on the span to determine what kind of start type the ``` Closes: INGEST-631
1 parent 4e7783f commit 8309e51

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ dependencies = [
8181
# [end] jsonschema format validators
8282
"sentry-arroyo>=2.33.1",
8383
"sentry-forked-email-reply-parser>=0.5.12.post1",
84-
"sentry-kafka-schemas>=2.1.13",
84+
"sentry-kafka-schemas>=2.1.15",
8585
"sentry-ophio>=1.1.3",
8686
"sentry-protos>=0.4.2",
8787
"sentry-redis-tools>=0.5.0",

src/sentry/spans/consumers/process_segments/convert.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
"end_timestamp": "sentry.end_timestamp_precise",
1616
"event_id": "sentry.event_id",
1717
"hash": "sentry.hash",
18-
"kind": "sentry.kind",
1918
"name": "sentry.name",
2019
"parent_span_id": "sentry.parent_span_id",
2120
"received": "sentry.received",

uv.lock

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)