Skip to content

Commit 76bade1

Browse files
nsdeschenesClaude Opus 4.6
andcommitted
ref(explore): Rename useAsyncAttributeValidation to useAttributeValidation
Co-Authored-By: Claude Opus 4.6 <noreply@example.com>
1 parent dd75700 commit 76bade1

3 files changed

Lines changed: 14 additions & 20 deletions

File tree

static/app/views/explore/components/traceItemSearchQueryBuilder.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ import {FieldKind, getFieldDefinition} from 'sentry/utils/fields';
1515
import {getHasTag} from 'sentry/utils/tag';
1616
import {
1717
extractFilterKeys,
18-
useAsyncAttributeValidation,
19-
} from 'sentry/views/explore/hooks/useAsyncAttributeValidation';
18+
useAttributeValidation,
19+
} from 'sentry/views/explore/hooks/useAttributeValidation';
2020
import {useExploreSuggestedAttribute} from 'sentry/views/explore/hooks/useExploreSuggestedAttribute';
2121
import {useGetTraceItemAttributeTagKeys} from 'sentry/views/explore/hooks/useGetTraceItemAttributeTagKeys';
2222
import {useGetTraceItemAttributeValues} from 'sentry/views/explore/hooks/useGetTraceItemAttributeValues';
@@ -117,7 +117,7 @@ export function useTraceItemSearchQueryBuilderProps({
117117
() => extractFilterKeys(parseSearch(currentQuery)),
118118
[currentQuery]
119119
);
120-
const invalidFilterKeys = useAsyncAttributeValidation(itemType, filterKeys, projects);
120+
const invalidFilterKeys = useAttributeValidation(itemType, filterKeys, projects);
121121

122122
const wrappedOnChange = useCallback(
123123
(query: string, state: CallbackSearchState) => {

static/app/views/explore/hooks/useAsyncAttributeValidation.spec.tsx renamed to static/app/views/explore/hooks/useAttributeValidation.spec.tsx

Lines changed: 10 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ import type {ParseResult} from 'sentry/components/searchSyntax/parser';
55
import {Token} from 'sentry/components/searchSyntax/parser';
66
import {
77
extractFilterKeys,
8-
useAsyncAttributeValidation,
9-
} from 'sentry/views/explore/hooks/useAsyncAttributeValidation';
8+
useAttributeValidation,
9+
} from 'sentry/views/explore/hooks/useAttributeValidation';
1010
import {TraceItemDataset} from 'sentry/views/explore/types';
1111

1212
describe('extractFilterKeys', () => {
@@ -63,7 +63,7 @@ describe('extractFilterKeys', () => {
6363
});
6464
});
6565

66-
describe('useAsyncAttributeValidation', () => {
66+
describe('useAttributeValidation', () => {
6767
beforeEach(() => {
6868
MockApiClient.clearMockResponses();
6969

@@ -86,7 +86,7 @@ describe('useAsyncAttributeValidation', () => {
8686

8787
it('returns empty array when filterKeys is empty', () => {
8888
const {result} = renderHookWithProviders(() =>
89-
useAsyncAttributeValidation(TraceItemDataset.SPANS, [])
89+
useAttributeValidation(TraceItemDataset.SPANS, [])
9090
);
9191

9292
expect(result.current).toEqual([]);
@@ -105,7 +105,7 @@ describe('useAsyncAttributeValidation', () => {
105105
});
106106

107107
const {result} = renderHookWithProviders(() =>
108-
useAsyncAttributeValidation(TraceItemDataset.SPANS, ['span.op', 'bad.key'])
108+
useAttributeValidation(TraceItemDataset.SPANS, ['span.op', 'bad.key'])
109109
);
110110

111111
await waitFor(() => {
@@ -126,7 +126,7 @@ describe('useAsyncAttributeValidation', () => {
126126
});
127127

128128
const {result} = renderHookWithProviders(() =>
129-
useAsyncAttributeValidation(TraceItemDataset.SPANS, ['span.op', 'span.duration'])
129+
useAttributeValidation(TraceItemDataset.SPANS, ['span.op', 'span.duration'])
130130
);
131131

132132
await waitFor(() => {
@@ -148,11 +148,7 @@ describe('useAsyncAttributeValidation', () => {
148148
});
149149

150150
const {result} = renderHookWithProviders(() =>
151-
useAsyncAttributeValidation(TraceItemDataset.SPANS, [
152-
'bad.one',
153-
'bad.two',
154-
'good.key',
155-
])
151+
useAttributeValidation(TraceItemDataset.SPANS, ['bad.one', 'bad.two', 'good.key'])
156152
);
157153

158154
await waitFor(() => {
@@ -172,7 +168,7 @@ describe('useAsyncAttributeValidation', () => {
172168
});
173169

174170
renderHookWithProviders(() =>
175-
useAsyncAttributeValidation(TraceItemDataset.LOGS, ['log.level'])
171+
useAttributeValidation(TraceItemDataset.LOGS, ['log.level'])
176172
);
177173

178174
await waitFor(() => {
@@ -205,7 +201,7 @@ describe('useAsyncAttributeValidation', () => {
205201
});
206202

207203
renderHookWithProviders(() =>
208-
useAsyncAttributeValidation(TraceItemDataset.SPANS, ['span.op'], [2, 3])
204+
useAttributeValidation(TraceItemDataset.SPANS, ['span.op'], [2, 3])
209205
);
210206

211207
await waitFor(() => {
@@ -227,9 +223,7 @@ describe('useAsyncAttributeValidation', () => {
227223
body: {attributes: {}},
228224
});
229225

230-
renderHookWithProviders(() =>
231-
useAsyncAttributeValidation(TraceItemDataset.SPANS, [])
232-
);
226+
renderHookWithProviders(() => useAttributeValidation(TraceItemDataset.SPANS, []));
233227

234228
expect(mockRequest).not.toHaveBeenCalled();
235229
});

static/app/views/explore/hooks/useAsyncAttributeValidation.tsx renamed to static/app/views/explore/hooks/useAttributeValidation.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ export function extractFilterKeys(parsedQuery: ParseResult | null): string[] {
4848
* Uses useApiQuery for automatic deduplication, caching, and
4949
* stale response handling.
5050
*/
51-
export function useAsyncAttributeValidation(
51+
export function useAttributeValidation(
5252
itemType: TraceItemDataset,
5353
filterKeys: string[],
5454
projects?: PageFilters['projects']

0 commit comments

Comments
 (0)