Skip to content

Commit 4ca9020

Browse files
noahsmartinbillyvg
authored andcommitted
ref: Remove PlanTier prop from subscription (#117881)
This is finally not used! Only a handful of places that sent it as an analytics tag, most also tracked the plan id itself which has more information than the tier. Removed these analytics use cases and completely deleted the type definition.
1 parent 40bd96c commit 4ca9020

30 files changed

Lines changed: 5 additions & 102 deletions

static/gsAdmin/components/changePlanAction.spec.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ describe('ChangePlanAction', () => {
2121
const mockOrg = OrganizationFixture({slug: 'org-slug'});
2222
const subscription = SubscriptionFixture({
2323
organization: mockOrg,
24-
planTier: PlanTier.AM3,
2524
plan: 'am3_business',
2625
billingInterval: 'monthly',
2726
contractInterval: 'monthly',
@@ -264,7 +263,6 @@ describe('ChangePlanAction', () => {
264263
// Create subscription with Seer budget
265264
const subscriptionWithSeer = SubscriptionWithLegacySeerFixture({
266265
organization: mockOrg,
267-
planTier: PlanTier.AM3,
268266
plan: 'am3_business',
269267
});
270268

static/gsAdmin/components/customerStatus.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@ type Props = {
1212

1313
const getLabel = (item: Subscription) => {
1414
if (item.isEnterpriseTrial) {
15-
return `Trialing (${item.trialTier} enterprise)`;
15+
return `Trialing (${item.trialPlan} enterprise)`;
1616
}
1717
if (item.isTrial) {
18-
return `Trialing (${item.trialTier})`;
18+
return `Trialing (${item.trialPlan})`;
1919
}
2020
if (item.isFree) {
2121
return 'Free Account';

static/gsAdmin/components/customers/customerOverview.spec.tsx

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import {
88
SubscriptionFixture,
99
SubscriptionWithLegacySeerFixture,
1010
} from 'getsentry-test/fixtures/subscription';
11-
import {PlanTier} from 'getsentry-test/planTier';
1211
import {
1312
render,
1413
screen,
@@ -376,7 +375,6 @@ describe('CustomerOverview', () => {
376375
const enterprise_subscription = InvoicedSubscriptionFixture({
377376
organization,
378377
plan: 'am3_business_ent_auf',
379-
planTier: PlanTier.AM3,
380378
});
381379

382380
render(
@@ -403,7 +401,6 @@ describe('CustomerOverview', () => {
403401
const subscription = SubscriptionFixture({
404402
organization,
405403
plan: 'am3_f',
406-
planTier: PlanTier.AM3,
407404
});
408405

409406
render(
@@ -427,7 +424,6 @@ describe('CustomerOverview', () => {
427424
const am3Subscription = SubscriptionFixture({
428425
organization,
429426
plan: 'am3_f',
430-
planTier: PlanTier.AM3,
431427
productTrials: [
432428
{
433429
category: DataCategory.REPLAYS,
@@ -604,7 +600,6 @@ describe('CustomerOverview', () => {
604600
const am3Subscription = SubscriptionFixture({
605601
organization,
606602
plan: 'am3_team',
607-
planTier: PlanTier.AM3,
608603
});
609604

610605
MockApiClient.addMockResponse({

static/gsAdmin/views/customerDetails.spec.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1104,7 +1104,6 @@ describe('Customer Details', () => {
11041104
const subscription = SubscriptionFixture({
11051105
organization,
11061106
plan: 'am3_f',
1107-
planTier: 'am3',
11081107
});
11091108
subscription.reservedBudgets = [
11101109
SeerReservedBudgetFixture({

static/gsApp/components/features/insightsDateRangeQueryLimitFooter.spec.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ describe('InsightsUpsellPage', () => {
1313
organization,
1414
plan: 'am3_team',
1515
isFree: true,
16-
planTier: PlanTier.AM3,
1716
});
1817

1918
beforeEach(() => {

static/gsApp/components/performance/quotaExceededAlert.spec.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ describe('Renders QuotaExceededAlert correctly for spans', () => {
3030
onDemandBudgets: {
3131
enabled: true,
3232
} as any,
33-
planTier: 'am1' as any,
3433
categories: {
3534
spans: {
3635
usageExceeded: spansUsageExceeded,

static/gsApp/components/profiling/profilingUpgradeModal.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ function UpsellModal(props: Props) {
6060
useEffect(() => {
6161
trackGetsentryAnalytics('upgrade_now.modal.viewed', {
6262
organization,
63-
planTier: subscription.planTier,
6463
canSelfServe: subscription.canSelfServe,
6564
channel: subscription.channel,
6665
has_billing_scope: organization.access?.includes('org:billing'),
@@ -219,7 +218,6 @@ function ActionButtons({
219218

220219
trackGetsentryAnalytics('upgrade_now.modal.update_now', {
221220
organization,
222-
planTier: subscription.planTier,
223221
canSelfServe: subscription.canSelfServe,
224222
channel: subscription.channel,
225223
has_billing_scope: organization.access?.includes('org:billing'),
@@ -243,7 +241,6 @@ function ActionButtons({
243241
trackGetsentryAnalytics('upgrade_now.modal.manage_sub', {
244242
organization,
245243
surface: 'profiling',
246-
planTier: subscription.planTier,
247244
canSelfServe: subscription.canSelfServe,
248245
channel: subscription.channel,
249246
has_billing_scope: organization.access?.includes('org:billing'),

static/gsApp/components/replayOnboardingCTA.tsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ function ReplayOnboardingCTAUpsell({
4949
trackGetsentryAnalytics('replay.list_page.viewed', {
5050
organization,
5151
surface: 'replay_onboarding_banner',
52-
planTier: subscription.planTier,
5352
canSelfServe: subscription.canSelfServe,
5453
channel: subscription.channel,
5554
has_billing_scope: organization.access?.includes('org:billing'),
@@ -67,7 +66,6 @@ function ReplayOnboardingCTAUpsell({
6766
trackGetsentryAnalytics('replay.list_page.sent_email', {
6867
organization,
6968
surface: 'replay_onboarding_banner',
70-
planTier: subscription.planTier,
7169
canSelfServe: subscription.canSelfServe,
7270
channel: subscription.channel,
7371
has_billing_scope: organization.access?.includes('org:billing'),
@@ -112,7 +110,6 @@ function ReplayOnboardingCTAUpsell({
112110
trackGetsentryAnalytics('replay.list_page.open_modal', {
113111
organization,
114112
surface: 'replay_onboarding_banner',
115-
planTier: subscription.planTier,
116113
canSelfServe: subscription.canSelfServe,
117114
channel: subscription.channel,
118115
has_billing_scope: hasBillingAccess,
@@ -156,7 +153,6 @@ function ReplayOnboardingCTAUpsell({
156153
trackGetsentryAnalytics('replay.list_page.manage_sub', {
157154
organization,
158155
surface: 'replay_onboarding_banner',
159-
planTier: subscription.planTier,
160156
canSelfServe: subscription.canSelfServe,
161157
channel: subscription.channel,
162158
has_billing_scope: organization.access?.includes('org:billing'),

static/gsApp/components/upgradeNowModal/actionButtons.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,6 @@ export function ActionButtons({
7070

7171
trackGetsentryAnalytics('upgrade_now.modal.update_now', {
7272
organization,
73-
planTier: subscription.planTier,
7473
canSelfServe: subscription.canSelfServe,
7574
channel: subscription.channel,
7675
has_billing_scope: organization.access?.includes('org:billing'),
@@ -101,7 +100,6 @@ export function ActionButtons({
101100
trackGetsentryAnalytics('upgrade_now.modal.sent_email', {
102101
organization,
103102
surface,
104-
planTier: subscription.planTier,
105103
canSelfServe: subscription.canSelfServe,
106104
channel: subscription.channel,
107105
has_billing_scope: organization.access?.includes('org:billing'),
@@ -123,7 +121,6 @@ export function ActionButtons({
123121
trackGetsentryAnalytics('upgrade_now.modal.manage_sub', {
124122
organization,
125123
surface,
126-
planTier: subscription.planTier,
127124
canSelfServe: subscription.canSelfServe,
128125
channel: subscription.channel,
129126
has_billing_scope: organization.access?.includes('org:billing'),

static/gsApp/components/upgradeNowModal/modalSamePrice.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ function UpgradeNowModal({
6666

6767
trackGetsentryAnalytics('upgrade_now.modal.update_now', {
6868
organization,
69-
planTier: subscription.planTier,
7069
canSelfServe: subscription.canSelfServe,
7170
channel: subscription.channel,
7271
has_billing_scope: organization.access?.includes('org:billing'),

0 commit comments

Comments
 (0)