Merge branch 'master' into ognjenbostjancic/tet-2453-support-thinking-messages-in-product

Author: obostjancic

.agents/skills/cell-architecture/SKILL.md

@@ -8,9 +8,8 @@ description: >-
   URL_NAME_TO_ACTION registry in test_urls.py to zero (with a recipe for each action type),
   rolling deploy safety and the two-phase pattern required by independent sentry/getsentry deploys,
   and the region -> cell rename including what not to rename (DB columns, AWS refs, uptime regions,
-  billing address). Also documents known issues with proposed fixes: org listing and creation
-  without a slug, integration TeamLinkageView routing, Jira cross-cell fan-out, and relocation
-  endpoint routing.
+  billing address). Also documents known issues with proposed fixes: integration TeamLinkageView
+  routing, Jira cross-cell fan-out, and relocation endpoint routing.
 ---
 
 > **Status**: Active migration in progress. Migration-specific sections should be removed once complete, leaving a stable architecture reference.
@@ -245,17 +244,6 @@ the context before renaming.
 
 Specific broken areas with a description of the problem and the proposed fix. Remove each entry once resolved.
 
-#### Org Operations Without an Existing Org Slug
-
-Several org lifecycle operations have no existing org slug to route by, so Synapse can't route them to a specific cell within a locality:
-
-- **Org listing** — the frontend fans out `/organizations/` to each locality URL (`useOrganizationsWithRegion`). `OrganizationIndexEndpoint` is `@cell_silo_endpoint` and queries `Organization.objects.get_for_user_ids()`, so even if it reaches a cell it only returns orgs in that cell.
-- **Org creation** — the user picks a locality but there's no mechanism to select which cell within that locality the new org lands in.
-
-**The fix for listing**: move `OrganizationIndexEndpoint` to `@control_silo_endpoint` and query `OrganizationMemberMapping` (user -> org IDs) joined with `OrganizationMapping` — both already exist on control silo. Some response fields (e.g. avatar, auth provider, features) are not yet in `OrganizationMapping` and would need to be replicated or dropped.
-
-**Org creation**: `Locality.new_org_cell` to route new orgs to the correct cell within the selected locality.
-
 #### Integration Views and Cell Routing
 
 `TeamLinkageView` (link-team, unlink-team) is broken in two ways: it uses signed URLs with `integration_id` instead of org slug so Synapse can't route it, and it queries `OrganizationMember.get_for_integration()` (cell-silo) so it only sees orgs in the current locality anyway.

.github/CODEOWNERS

@@ -176,6 +176,7 @@ build-utils/                                             @getsentry/owners-js-bu
 eslint.config.ts                                         @getsentry/owners-js-build
 jest-balance.json                                        @getsentry/owners-js-build
 jest.config.ts                                           @getsentry/owners-js-build
+/tests/js/test-balancer/                                 @getsentry/owners-js-build
 tsconfig.*                                               @getsentry/owners-js-build
 .node-version                                            @getsentry/owners-js-deps
 package.json                                             @getsentry/owners-js-deps

.github/codeowners-coverage-baseline.txt

@@ -1846,7 +1846,6 @@ tests/js/instrumentedEnv/userEventIntegration.ts
 tests/js/jest-pegjs-transform.js
 tests/js/setup.ts
 tests/js/setupFramework.ts
-tests/js/test-balancer/index.js
 tests/sentry/__init__.py
 tests/sentry/analytics/__init__.py
 tests/sentry/analytics/test_base.py

.github/workflows/frontend-snapshots.yml

@@ -65,6 +65,10 @@ jobs:
         run: pnpm exec playwright install chromium --with-deps
 
       - name: Run snapshot tests
+        env:
+          SENTRY_DSN: ${{ secrets.SENTRY_SNAPSHOTS_DSN }}
+          GITHUB_PR_SHA: ${{ github.event.pull_request.head.sha || github.sha }}
+          GITHUB_PR_REF: ${{ github.event.pull_request.head.ref || github.ref }}
         run: pnpm run snapshots
 
       - name: Compute merge base SHA

.github/workflows/jest-balance.yml

@@ -4,24 +4,98 @@ on:
   schedule:
     - cron: '0 0 1,15 * *'
 jobs:
+  jest-config:
+    name: Configure Jest
+    runs-on: ubuntu-24.04
+    timeout-minutes: 5
+    outputs:
+      jest_test_matrix: ${{ steps.jest_test_config.outputs.jest_test_matrix }}
+    steps:
+      - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+        name: Checkout sentry
+
+      - uses: ./.github/actions/setup-node-pnpm
+
+      - name: Jest Test Config
+        id: jest_test_config
+        env:
+          FRONTEND_ALL_FILES: ''
+        run: ./.github/workflows/scripts/jest-test-config.sh
+
+      - uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # 4.6.2
+        name: Upload jest test file list
+        with:
+          name: jest-test-files
+          path: jest-test-files.json
+          if-no-files-found: ignore
+          retention-days: 1
+
   jest-balance:
-    # Buckle up, this may take a while
+    needs: jest-config
     timeout-minutes: 60
     # Make sure this matches the runner that runs frontend tests
     runs-on: ubuntu-24.04
+    strategy:
+      fail-fast: false
+      matrix: ${{ fromJson(needs.jest-config.outputs.jest_test_matrix) }}
     steps:
       - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+        name: Checkout sentry
 
       - uses: ./.github/actions/setup-node-pnpm
 
-      - name: jest balancer
+      - uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0
+        name: Download jest-test-files.json
+        with:
+          name: jest-test-files
+          path: .
+
+      - name: Download jest-balance.json
+        uses: dawidd6/action-download-artifact@ac66b43f0e6a346234dd65d4d0c8fbb31cb316e5 # v11
+        with:
+          workflow: 38531594 # jest-balancer.yml
+          workflow_conclusion: success
+          branch: master
+          name: jest-balance.json
+          name_is_regexp: false
+          path: tests/js/test-balancer/
+          search_artifacts: true
+          if_no_artifact_found: warn
+
+      - name: jest balancer (shard ${{ matrix.index }}/${{ matrix.total }})
+        continue-on-error: true
         env:
+          SENTRY_DSN: ${{ secrets.SENTRY_JEST_DSN }}
+
+          CI_NODE_TOTAL: ${{ matrix.total }}
+          CI_NODE_INDEX: ${{ matrix.index }}
+
           GITHUB_PR_SHA: ${{ github.event.pull_request.head.sha || github.sha }}
           GITHUB_PR_REF: ${{ github.event.pull_request.head.ref || github.ref }}
-          SENTRY_DSN: ${{ secrets.SENTRY_JEST_DSN }}
-        run: pnpm run test-ci --testResultsProcessor ./tests/js/test-balancer/index.js
+        run: pnpm run test-ci --forceExit --testResultsProcessor ./tests/js/test-balancer/resultsProcessor.ts
 
       - uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # 4.6.2
         with:
-          name: jest-balance.json
+          name: jest-balance-${{ matrix.index }}
           path: tests/js/test-balancer/jest-balance.json
+
+  combine-balance:
+    needs: jest-balance
+    runs-on: ubuntu-24.04
+    steps:
+      - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+
+      - uses: ./.github/actions/setup-node-pnpm
+
+      - uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0
+        with:
+          path: artifacts
+          pattern: jest-balance-*
+
+      - name: Combine balance files
+        run: node tests/js/test-balancer/combine.ts artifacts
+
+      - uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # 4.6.2
+        with:
+          name: jest-balance.json
+          path: jest-balance.json