fix(action_log): Refine usage of idempotency key

Author: kcons

src/sentry/issues/action_log/__init__.py

@@ -1,7 +1,6 @@
 from sentry.issues.action_log.base import (
     ActionContext,
     ActionSource,
-    DuplicateActionError,
     action_context_scope,
     get_action_context,
     publish_action,
@@ -13,7 +12,6 @@
 __all__ = [
     "ActionContext",
     "ActionSource",
-    "DuplicateActionError",
     "GroupActionActor",
     "SYSTEM_ACTOR",
     "action_context_scope",

src/sentry/issues/action_log/base.py

@@ -7,7 +7,6 @@
 from dataclasses import dataclass
 from enum import StrEnum
 
-from django.db import IntegrityError, router, transaction
 from rest_framework.request import Request
 
 from sentry import options
@@ -134,10 +133,6 @@ def get_action_context() -> ActionContext | None:
     return _action_context.get()
 
 
-class DuplicateActionError(Exception):
-    """Raised when an idempotency_key conflicts with an existing entry."""
-
-
 def publish_action(
     action: GroupAction,
     *,
@@ -146,11 +141,9 @@ def publish_action(
     organization_id: int,
     project_id: int,
     actor: GroupActionActor = SYSTEM_ACTOR,
-    idempotency_key: str | None = None,
 ) -> None:
     """
-    Record an issue action. Raises DuplicateActionError if an idempotency_key
-    conflicts with an existing entry.
+    Record an issue action.
 
     Use this for shallow endpoint-level actions where the request is in scope
     (VIEW, COMMENT, TRIGGER_AUTOFIX). For mutation sites deeper in the stack,
@@ -171,42 +164,23 @@ def publish_action(
             "actor_type": actor.actor_type.name.lower(),
             "actor_id": str(actor.actor_id),
             "metadata": action.dict(),
-            "idempotency_key": idempotency_key,
         },
     )
 
     # Don't write to the database until we're confident in the action schemas.
     if not options.get("issues.action-log.write-to-db"):
         return
 
-    kwargs = dict(
+    GroupActionLogEntry.objects.create(
         group_id=group_id,
         project_id=project_id,
         type=action.get_type().value,
         actor_type=actor.actor_type.value,
         actor_id=actor.actor_id,
         source=source,
         data=action.dict(),
-        idempotency_key=idempotency_key,
     )
 
-    if idempotency_key is None:
-        GroupActionLogEntry.objects.create(**kwargs)
-        return
-
-    try:
-        with transaction.atomic(using=router.db_for_write(GroupActionLogEntry)):
-            GroupActionLogEntry.objects.create(**kwargs)
-    except IntegrityError as e:
-        cause = e.__cause__
-        constraint = getattr(getattr(cause, "diag", None), "constraint_name", None)
-        if constraint == "uniq_groupactionlogentry_group_idempotency_key":
-            raise DuplicateActionError(
-                f"Action already recorded for group {group_id} "
-                f"with idempotency_key={idempotency_key!r}"
-            ) from e
-        raise
-
 
 def publish_action_from_context(
     action: GroupAction,

src/sentry/issues/groupactionlogentry.py

@@ -59,7 +59,8 @@ class GroupActionLogEntry(Model):
     # for invalidation.
     date_updated = models.DateTimeField(auto_now=True)
 
-    # Partial unique index with group_id prevents duplicate events.
+    # Unique identifier for external action this corresponds to.
+    # Primarly exists to make backfilling third party actions simpler.
     idempotency_key = models.CharField(max_length=64, null=True)
 
     class Meta:

tests/sentry/issues/test_action_log.py

@@ -1,8 +1,6 @@
 from typing import Any
 from unittest.mock import MagicMock, patch
 
-import pytest
-
 import sentry.api.helpers.group_index.update
 import sentry.issues.endpoints.group_details
 import sentry.issues.endpoints.group_integration_details
@@ -14,7 +12,6 @@
 from sentry.issues.action_log import (
     SYSTEM_ACTOR,
     ActionContext,
-    DuplicateActionError,
     GroupActionActor,
     action_context_scope,
     get_action_context,
@@ -576,24 +573,6 @@ def test_multiple_entries_ordered(self) -> None:
         assert len(entries) == 3
         assert entries[0].id < entries[1].id < entries[2].id
 
-    def test_duplicate_idempotency_key_raises(self) -> None:
-        kwargs = dict(
-            source=ActionSource.API,
-            group_id=self.group.id,
-            organization_id=self.group.project.organization_id,
-            project_id=self.group.project_id,
-            actor=GroupActionActor.user(self.user.id),
-            idempotency_key="view-123",
-        )
-
-        with self.options({"issues.action-log.write-to-db": True}):
-            publish_action(ViewAction(), **kwargs)
-
-            with pytest.raises(DuplicateActionError):
-                publish_action(ViewAction(), **kwargs)
-
-        assert GroupActionLogEntry.objects.filter(group_id=self.group.id).count() == 1
-
     def test_option_disabled_skips_write(self) -> None:
         with self.options({"issues.action-log.write-to-db": False}):
             publish_action(