logs instead of exit code (#1976)

bitsandfoxes · web-flow · commit 3f0d108f96e9 · 2025-01-21T16:22:29.000+01:00
diff --git a/test/Scripts.Integration.Test/run-smoke-test.ps1 b/test/Scripts.Integration.Test/run-smoke-test.ps1
@@ -117,8 +117,9 @@ function RunTest([string] $type)
             Write-Host "$type test: Player.log contents END" -ForegroundColor Yellow
         }
 
-        # ExitCode 200 is the status code indicating success inside SmokeTest.cs
-        If ($process.ExitCode -eq 200)
+        # Relying on ExitCode does not seem reliable. We're looking for the line "SmokeTester is quitting." instead to indicate 
+        # a successful shut-down.
+        If ($appLog | Select-String "SmokeTester is quitting.")
         {
             Write-Host "$type test: PASSED" -ForegroundColor Green
         }

Original file line number	Diff line number	Diff line change
`@@ -117,8 +117,9 @@ function RunTest([string] $type)`
`117`	`117`	`Write-Host "$type test: Player.log contents END" -ForegroundColor Yellow`
`118`	`118`	`}`
`119`	`119`
`120`		`- # ExitCode 200 is the status code indicating success inside SmokeTest.cs`
`121`		`- If ($process.ExitCode -eq 200)`
	`120`	`+ # Relying on ExitCode does not seem reliable. We're looking for the line "SmokeTester is quitting." instead to indicate`
	`121`	`+ # a successful shut-down.`
	`122`	`+ If ($appLog \| Select-String "SmokeTester is quitting.")`
`122`	`123`	`{`
`123`	`124`	`Write-Host "$type test: PASSED" -ForegroundColor Green`
`124`	`125`	`}`