Skip to content

Commit de332aa

Browse files
committed
Review
1 parent c5cdd6d commit de332aa

File tree

2 files changed

+20
-1
lines changed

2 files changed

+20
-1
lines changed

src/Monolog/LogsHandler.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
use Monolog\Level as MonologLevel;
88
use Monolog\Logger as MonologLogger;
99
use Monolog\LogRecord;
10+
use Psr\Log\InvalidArgumentException;
1011
use Psr\Log\LogLevel as PsrLogLevel;
1112
use Sentry\Monolog\CompatibilityLogLevelTrait;
1213
use Sentry\Monolog\LogsHandler as BaseLogsHandler;
@@ -27,7 +28,11 @@ class LogsHandler extends BaseLogsHandler
2728
*/
2829
public function __construct($level = MonologLogger::DEBUG, bool $bubble = true)
2930
{
30-
$level = MonologLogger::toMonologLevel($level);
31+
try {
32+
$level = MonologLogger::toMonologLevel($level);
33+
} catch (InvalidArgumentException $e) {
34+
$level = MonologLogger::INFO;
35+
}
3136
if ($level instanceof MonologLevel) { // Monolog >= 3
3237
$level = $level->value;
3338
}

tests/Monolog/LogsHandlerTest.php

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,4 +84,18 @@ public static function levelProvider(): iterable
8484
yield [MonologLevel::Debug];
8585
}
8686
}
87+
88+
public function testHandlerFallbacksToInfoOnInvalidLevel(): void
89+
{
90+
/** @phpstan-ignore-next-line */
91+
$handler = new LogsHandler(123124213, false);
92+
$record = [
93+
'message' => 'msg',
94+
'context' => [],
95+
'extra' => [],
96+
];
97+
98+
$this->assertFalse($handler->handle($record + ['level' => MonologLogger::DEBUG]));
99+
$this->assertTrue($handler->handle($record + ['level' => MonologLogger::WARNING]));
100+
}
87101
}

0 commit comments

Comments
 (0)