Skip to content

Merge branch 'main' into alwx/feature/expo-router-integration

f741102
Select commit
Loading
Failed to load commit list.
Merged

Add a first-class expoRouterIntegration() with auto-registration (#6156) #6189

Merge branch 'main' into alwx/feature/expo-router-integration
f741102
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden: code-review completed May 20, 2026 in 7m 24s

2 issues

code-review: Found 2 issues (2 low)

Low

ExpoRouterIntegrationOptions not exported from the public API - `packages/core/etc/sentry-react-native.api.md:287-290`

The ExpoRouterIntegrationOptions type is used in the public signature of expoRouterIntegration but is not exported, so TypeScript consumers cannot reference this type explicitly when constructing options objects outside an inline call.

No test for expoRouterIntegration on web (notWeb = false) - `packages/core/test/integrations/defaultExpoRouter.test.ts:19-21`

The test always mocks notWeb to true but never tests the web scenario — consider adding a case to document whether the integration should be included on web, since the production code in default.ts (line 143) adds expoRouterIntegration() without a notWeb() guard unlike mobileReplayIntegration and debugSymbolicatorIntegration.


⏱ 7m 4s · 1.1M in / 66.7k out · $1.92